simplified if else logic

Author: Kaustav-Sarkar

vector/src/main/java/org/apache/arrow/vector/TimeStampMicroTZVector.java

@@ -155,12 +155,13 @@ public void set(int index, NullableTimeStampMicroTZHolder holder)
       throws IllegalArgumentException {
     if (holder.isSet < 0) {
       throw new IllegalArgumentException();
-    } else if (holder.isSet > 0 && !this.timeZone.equals(holder.timezone)) {
-      throw new IllegalArgumentException(
-          String.format(
-              "holder.timezone: %s not equal to vector timezone: %s",
-              holder.timezone, this.timeZone));
     } else if (holder.isSet > 0) {
+      if (!this.timeZone.equals(holder.timezone)) {
+        throw new IllegalArgumentException(
+            String.format(
+                "holder.timezone: %s not equal to vector timezone: %s",
+                holder.timezone, this.timeZone));
+      }
       BitVectorHelper.setBit(validityBuffer, index);
       setValue(index, holder.value);
     } else {

vector/src/main/java/org/apache/arrow/vector/TimeStampMilliTZVector.java

@@ -155,12 +155,13 @@ public void set(int index, NullableTimeStampMilliTZHolder holder)
       throws IllegalArgumentException {
     if (holder.isSet < 0) {
       throw new IllegalArgumentException();
-    } else if (holder.isSet > 0 && !this.timeZone.equals(holder.timezone)) {
-      throw new IllegalArgumentException(
-          String.format(
-              "holder.timezone: %s not equal to vector timezone: %s",
-              holder.timezone, this.timeZone));
     } else if (holder.isSet > 0) {
+      if (!this.timeZone.equals(holder.timezone)) {
+        throw new IllegalArgumentException(
+            String.format(
+                "holder.timezone: %s not equal to vector timezone: %s",
+                holder.timezone, this.timeZone));
+      }
       BitVectorHelper.setBit(validityBuffer, index);
       setValue(index, holder.value);
     } else {

vector/src/main/java/org/apache/arrow/vector/TimeStampNanoTZVector.java

@@ -154,12 +154,13 @@ public Long getObject(int index) {
   public void set(int index, NullableTimeStampNanoTZHolder holder) throws IllegalArgumentException {
     if (holder.isSet < 0) {
       throw new IllegalArgumentException();
-    } else if (holder.isSet > 0 && !this.timeZone.equals(holder.timezone)) {
-      throw new IllegalArgumentException(
-          String.format(
-              "holder.timezone: %s not equal to vector timezone: %s",
-              holder.timezone, this.timeZone));
     } else if (holder.isSet > 0) {
+      if (!this.timeZone.equals(holder.timezone)) {
+        throw new IllegalArgumentException(
+            String.format(
+                "holder.timezone: %s not equal to vector timezone: %s",
+                holder.timezone, this.timeZone));
+      }
       BitVectorHelper.setBit(validityBuffer, index);
       setValue(index, holder.value);
     } else {

vector/src/main/java/org/apache/arrow/vector/TimeStampSecTZVector.java

@@ -150,12 +150,13 @@ public Long getObject(int index) {
   public void set(int index, NullableTimeStampSecTZHolder holder) throws IllegalArgumentException {
     if (holder.isSet < 0) {
       throw new IllegalArgumentException();
-    } else if (holder.isSet > 0 && !this.timeZone.equals(holder.timezone)) {
-      throw new IllegalArgumentException(
-          String.format(
-              "holder.timezone: %s not equal to vector timezone: %s",
-              holder.timezone, this.timeZone));
     } else if (holder.isSet > 0) {
+      if (!this.timeZone.equals(holder.timezone)) {
+        throw new IllegalArgumentException(
+            String.format(
+                "holder.timezone: %s not equal to vector timezone: %s",
+                holder.timezone, this.timeZone));
+      }
       BitVectorHelper.setBit(validityBuffer, index);
       setValue(index, holder.value);
     } else {