Skip to content

Commit 55f3274

Browse files
RAMPART-454 Finish OpenSAML 5 / Axis2 2.0.x API migration in trust/integration
- getBuilderOrThrow -> ensureBuilder (OpenSAML 5 builder-factory API). - net.shibboleth.utilities.java.support.xml -> net.shibboleth.shared.xml (Shibboleth 9.x repackaging of ParserPool / BasicParserPool). - SubjectConfirmation.getConfirmationMethod() -> getURI() in the SAML 1.1 bearer integration test. - Switch the test axis2.xml transport senders from the HTTPClient4 classes (gone in Axis2 2.0) to HTTPClient5TransportSender.
1 parent aceacfe commit 55f3274

6 files changed

Lines changed: 10 additions & 10 deletions

File tree

modules/rampart-integration/src/test/java/org/apache/rahas/RahasSAMLTokenUTForBearerTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ public void validateRsponse(OMElement resp) {
9494
subConfirmationMethods.get(0));
9595
assertEquals("Subject Confirmation should be BEARER : urn:oasis:names:tc:SAML:1.0:cm:bearer",
9696
RahasConstants.SAML11_SUBJECT_CONFIRMATION_BEARER,
97-
subConfirmationMethods.get(0).getConfirmationMethod());
97+
subConfirmationMethods.get(0).getURI());
9898
}
9999

100100
/* (non-Javadoc)

modules/rampart-integration/src/test/resources/conf/axis2.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -139,12 +139,12 @@
139139
<transportSender name="local"
140140
class="org.apache.axis2.transport.local.LocalTransportSender"/>
141141
<transportSender name="http"
142-
class="org.apache.axis2.transport.http.impl.httpclient4.HTTPClient4TransportSender">
142+
class="org.apache.axis2.transport.http.impl.httpclient5.HTTPClient5TransportSender">
143143
<parameter name="PROTOCOL" locked="false">HTTP/1.1</parameter>
144144
<parameter name="Transfer-Encoding" locked="false">chunked</parameter>
145145
</transportSender>
146146
<transportSender name="https"
147-
class="org.apache.axis2.transport.http.impl.httpclient4.HTTPClient4TransportSender">
147+
class="org.apache.axis2.transport.http.impl.httpclient5.HTTPClient5TransportSender">
148148
<parameter name="PROTOCOL" locked="false">HTTP/1.1</parameter>
149149
<parameter name="Transfer-Encoding" locked="false">chunked</parameter>
150150
</transportSender>
@@ -258,7 +258,7 @@
258258
<phase name="OperationOutFaultPhase"/>
259259
<phase name="RMPhase"/>
260260
<phase name="PolicyDetermination"/>
261-
<phase name="MessageOut"/>
261+
<phase name="MessageOut"/>
262262
<phase name="Security"/>
263263
</phaseOrder>
264264
</axisconfig>

modules/rampart-trust/src/main/java/org/apache/rahas/impl/SAML2TokenIssuer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -448,7 +448,7 @@ protected Subject createSubjectWithHolderOfKeySubjectConfirmation(Document doc,
448448
}
449449

450450
private KeyInfoConfirmationDataType createKeyInfoConfirmationDataType() {
451-
SAMLObjectBuilder<KeyInfoConfirmationDataType> keyInfoSubjectConfirmationDataBuilder = (SAMLObjectBuilder<KeyInfoConfirmationDataType>) XMLObjectProviderRegistrySupport.getBuilderFactory().<KeyInfoConfirmationDataType>getBuilderOrThrow(KeyInfoConfirmationDataType.TYPE_NAME);
451+
SAMLObjectBuilder<KeyInfoConfirmationDataType> keyInfoSubjectConfirmationDataBuilder = (SAMLObjectBuilder<KeyInfoConfirmationDataType>) XMLObjectProviderRegistrySupport.getBuilderFactory().<KeyInfoConfirmationDataType>ensureBuilder(KeyInfoConfirmationDataType.TYPE_NAME);
452452

453453
//Build the subject confirmation data element
454454
return keyInfoSubjectConfirmationDataBuilder.

modules/rampart-trust/src/main/java/org/apache/rahas/impl/util/AxiomParserPool.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@
2626

2727
import org.apache.axiom.om.OMAbstractFactory;
2828
import org.apache.axiom.om.dom.DOMMetaFactory;
29-
import net.shibboleth.utilities.java.support.xml.ParserPool;
30-
import net.shibboleth.utilities.java.support.xml.BasicParserPool;
29+
import net.shibboleth.shared.xml.ParserPool;
30+
import net.shibboleth.shared.xml.impl.BasicParserPool;
3131

3232
/**
3333
* Custom OpenSAML {@link ParserPool} implementation that uses a DOM aware Axiom implementation

modules/rampart-trust/src/main/java/org/apache/rahas/impl/util/CommonUtil.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -435,7 +435,7 @@ public static XMLObject buildXMLObject(QName objectQName) throws TrustException
435435
}
436436

437437
}
438-
XMLObjectBuilder builder = builderFactory.getBuilderOrThrow(objectQName);
438+
XMLObjectBuilder builder = builderFactory.ensureBuilder(objectQName);
439439
if (builder == null) {
440440
log.error("Unable to find OpenSAML builder for object " + objectQName);
441441
throw new TrustException("builderNotFound",new Object[]{objectQName});

modules/rampart-trust/src/main/java/org/apache/rahas/impl/util/SAMLUtils.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ public static Collection<X509Certificate> getCertChainCollection(X509Certificate
8585
*/
8686
public static Assertion buildAssertion(Element assertionElement) {
8787

88-
final SAMLObjectBuilder<Assertion> assertionBuilder = (SAMLObjectBuilder<Assertion>) XMLObjectProviderRegistrySupport.getBuilderFactory().<Assertion>getBuilderOrThrow(Assertion.DEFAULT_ELEMENT_NAME);
88+
final SAMLObjectBuilder<Assertion> assertionBuilder = (SAMLObjectBuilder<Assertion>) XMLObjectProviderRegistrySupport.getBuilderFactory().<Assertion>ensureBuilder(Assertion.DEFAULT_ELEMENT_NAME);
8989

9090
return assertionBuilder.buildObject();
9191
}
@@ -484,7 +484,7 @@ public static Attribute createAttribute(String name, String namespace, String va
484484

485485
XMLObjectBuilderFactory builderFactory = XMLObjectProviderRegistrySupport.getBuilderFactory();
486486

487-
XMLObjectBuilder<XSString> builder = builderFactory.getBuilderOrThrow(XSString.TYPE_NAME);
487+
XMLObjectBuilder<XSString> builder = builderFactory.ensureBuilder(XSString.TYPE_NAME);
488488

489489
XSString stringValue = builder.buildObject(AttributeValue.DEFAULT_ELEMENT_NAME, XSString.TYPE_NAME);
490490
stringValue.setValue(value);

0 commit comments

Comments
 (0)