BUG REPORT
Describe the bug
When a topology change occurs and it's communicated to the policy by onClusterChange(), if slave is not null and the change correspond to the deletion of a bookie, the list returned from onClusterChange() is empty.
To Reproduce
Get my branch and execute the command:
mvn -Dtest=OnClusterChangeREPPTest test -pl bookkeeper-server
This command execute the test that follows this steps:
- Initialize the policy with
stabilizePeriodSecond > 0.
- Call
onClusterChange() a first time specifying at least one writableBookies.
- Call
onClusterChange() a second time specifying a set of writableBookies where lacks at least one bookie specified in the previous step.
Expected behavior
The method should return the remove bookie (but return an empty list).
Screenshots
In this first screenshot note the deadBookies size (equals to 1):

After the execution of onClusterChange() to the slave the size becomes 0 and the information about dead bookies is missed:

Additional context
At this link is available possible fix for the method onClusterChange(). The original implementation can be seen at this link.
(Ticket was opened with the support of @gulyx)
BUG REPORT
Describe the bug
When a topology change occurs and it's communicated to the policy by
onClusterChange(), if slave is not null and the change correspond to the deletion of a bookie, the list returned fromonClusterChange()is empty.To Reproduce
Get my branch and execute the command:
This command execute the test that follows this steps:
stabilizePeriodSecond > 0.onClusterChange()a first time specifying at least one writableBookies.onClusterChange()a second time specifying a set of writableBookies where lacks at least one bookie specified in the previous step.Expected behavior
The method should return the remove bookie (but return an empty list).
Screenshots

In this first screenshot note the deadBookies size (equals to 1):
After the execution of

onClusterChange()to the slave the size becomes 0 and the information about dead bookies is missed:Additional context
At this link is available possible fix for the method
onClusterChange(). The original implementation can be seen at this link.(Ticket was opened with the support of @gulyx)