CASSSIDECAR-461: Validate snapshot name during list snapshot#348
Open
frankgh wants to merge 3 commits into
Open
CASSSIDECAR-461: Validate snapshot name during list snapshot#348frankgh wants to merge 3 commits into
frankgh wants to merge 3 commits into
Conversation
frankgh
commented
May 15, 2026
| */ | ||
| String validateSnapshotName(@NotNull String snapshotName); | ||
| default String validateSnapshotName(@NotNull String snapshotName) | ||
| { |
Contributor
Author
There was a problem hiding this comment.
moved implementation to default implementation in the interface. RegexBasedCassandraInputValidator didn't seem the appropriate place for a non-regex validation
frankgh
commented
May 15, 2026
| return SnapshotRequestParam.builder() | ||
| .qualifiedTableName(qualifiedTableName(context)) | ||
| .snapshotName(context.pathParam("snapshot")) | ||
| .snapshotName(validator.validateSnapshotName(context.pathParam("snapshot"))) |
Contributor
Author
There was a problem hiding this comment.
I realized this might not be a real issue because we can't have / or \0 (null character) in the path parameter. I tried coming up with a test, but the request fails before reaching the snapshot handler with a 404 (because the route is incorrect). I think we should still do the validation here in case in the future the snapshot name validation changes.
pauloricardomg
approved these changes
May 21, 2026
Patch by Francisco Guerrero; reviewed by TBD for CASSSIDECAR-461
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch by Francisco Guerrero; reviewed by TBD for CASSSIDECAR-461