Skip to content

Addition of description field for NIC's secondary IP addresses #12864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
erikbocks wants to merge 6 commits into
base: main
Choose a base branch
from

Address copilot's review

02a1d07
Select commit
Loading
Failed to load commit list.
Refresh
Open

Addition of description field for NIC's secondary IP addresses #12864

Address copilot's review
02a1d07
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Mar 20, 2026 in 0s

18.02% (-0.01%) compared to b744824

View this Pull Request on Codecov

18.02% (-0.01%) compared to b744824

Details

Codecov Report

❌ Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.02%. Comparing base (b744824) to head (02a1d07).

Files with missing lines Patch % Lines
...c/main/java/com/cloud/vm/dao/NicSecondaryIpVO.java 0.00% 8 Missing ⚠️
...loudstack/api/response/NicSecondaryIpResponse.java 0.00% 6 Missing ⚠️
...src/main/java/com/cloud/api/ApiResponseHelper.java 0.00% 2 Missing ⚠️
...ain/java/com/cloud/network/NetworkServiceImpl.java 0.00% 2 Missing ⚠️
...loudstack/api/command/user/vm/AddIpToVmNicCmd.java 0.00% 1 Missing ⚠️
...ava/com/cloud/api/query/dao/UserVmJoinDaoImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #12864      +/-   ##
============================================
- Coverage     18.02%   18.02%   -0.01%     
+ Complexity    16450    16449       -1     
============================================
  Files          5968     5968              
  Lines        537086   537105      +19     
  Branches      65961    65961              
============================================
- Hits          96819    96796      -23     
- Misses       429347   429389      +42     
  Partials      10920    10920

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov