From af4436280bdab53e0063268e92ff29b3fdcb1b07 Mon Sep 17 00:00:00 2001 From: tison Date: Thu, 25 Jun 2026 02:42:14 +0800 Subject: [PATCH 1/2] Fix count-min sketches test snapshots should use binary mode Signed-off-by: tison --- count/test/count_min_test.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/count/test/count_min_test.cpp b/count/test/count_min_test.cpp index 8b7ae0a7..5ce06859 100644 --- a/count/test/count_min_test.cpp +++ b/count/test/count_min_test.cpp @@ -215,7 +215,7 @@ TEST_CASE("CountMin sketch: serialize-deserialize empty", "[cm_sketch]") { for (auto di: d) { REQUIRE(di == 0); } - std::ofstream os("count_min-empty.bin"); + std::ofstream os("count_min-empty.bin", std::ios::binary); c.serialize(os); } @@ -243,7 +243,7 @@ TEST_CASE("CountMin sketch: serialize-deserialize non-empty", "[cm_sketch]") { ++d_it; } - std::ofstream os("count_min-non-empty.bin"); + std::ofstream os("count_min-non-empty.bin", std::ios::binary); c.serialize(os); } From 7c993ed201dced4458ee72954642aabfa80708c8 Mon Sep 17 00:00:00 2001 From: tison Date: Thu, 25 Jun 2026 14:58:49 +0800 Subject: [PATCH 2/2] Unify snapshot test files name Signed-off-by: tison --- count/test/count_min_test.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/count/test/count_min_test.cpp b/count/test/count_min_test.cpp index 5ce06859..64ffd4c0 100644 --- a/count/test/count_min_test.cpp +++ b/count/test/count_min_test.cpp @@ -215,7 +215,7 @@ TEST_CASE("CountMin sketch: serialize-deserialize empty", "[cm_sketch]") { for (auto di: d) { REQUIRE(di == 0); } - std::ofstream os("count_min-empty.bin", std::ios::binary); + std::ofstream os("count_min_empty_cpp.sk", std::ios::binary); c.serialize(os); } @@ -243,7 +243,7 @@ TEST_CASE("CountMin sketch: serialize-deserialize non-empty", "[cm_sketch]") { ++d_it; } - std::ofstream os("count_min-non-empty.bin", std::ios::binary); + std::ofstream os("count_min_non_empty_cpp.sk", std::ios::binary); c.serialize(os); }