Skip to content

Commit 6b1c38d

Browse files
committed
Fix to generate proper Apple Silicon wheels, bump versions to mitigate GH warnings
1 parent 28a5602 commit 6b1c38d

2 files changed

Lines changed: 7 additions & 6 deletions

File tree

.github/workflows/build_wheels.yml

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -69,10 +69,10 @@ jobs:
6969

7070
steps:
7171
- name: Checkout
72-
uses: actions/checkout@v3
72+
uses: actions/checkout@v4
7373

7474
- name: Set up Python 3.x
75-
uses: actions/setup-python@v4
75+
uses: actions/setup-python@v5
7676
with:
7777
python-version: '3.x'
7878

@@ -88,8 +88,12 @@ jobs:
8888
- name: Build wheels
8989
run: python -m cibuildwheel --output-dir dist
9090
env:
91+
CIBW_ENVIRONMENT_MACOS: CMAKE_OSX_ARCHITECTURES=${{ matrix.config.cibw-arch == 'macosx_x86_64' && 'x86_64' || matrix.config.cibw-arch == 'macosx_arm64' && 'arm64' || '' }}
9192
CIBW_BUILD: "*-${{ matrix.config.cibw-arch }}"
93+
MACOSX_DEPLOYMENT_TARGET: "10.14" # min supporting c++17
9294

93-
- uses: actions/upload-artifact@v3
95+
- uses: actions/upload-artifact@v4
9496
with:
97+
name: pypi_wheels
9598
path: ./dist/*.whl
99+
compression-level: 0 # contents are already compressed

pyproject.toml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,3 @@ before-build = "yum remove -y cmake"
3636

3737
[tool.cibuildwheel.macos]
3838
archs = ["x86_64", "arm64"]
39-
40-
# Minimum version for proper C++17 support on MacOS
41-
environment = { MACOSX_DEPLOYMENT_TARGET = "10.14" }

0 commit comments

Comments
 (0)