From 1e834ef5261095e6bcf7d036d0328f3729a1d1ff Mon Sep 17 00:00:00 2001 From: yujun Date: Fri, 29 May 2026 11:07:38 +0800 Subject: [PATCH] [fix](fe) Remove decimal literal debug logs (#63841) ### What problem does this PR solve? Decimal literal cast and construction paths print high-frequency INFO debug logs. In FE runtime these logs can be routed through stderr and appear as ERROR lines, flooding FE logs during normal query traffic. The noisy logs were introduced by #50940. This PR removes the debug logs from the decimal literal hot paths. ### Check List - Test: Unit Test - LiteralTest - Behavior changed: No - Does this need documentation: No --- .../nereids/trees/expressions/literal/DecimalV3Literal.java | 5 ----- .../doris/nereids/trees/expressions/literal/Literal.java | 4 ---- 2 files changed, 9 deletions(-) diff --git a/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/DecimalV3Literal.java b/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/DecimalV3Literal.java index cdb9969effcec3..c8c161b35bdc79 100644 --- a/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/DecimalV3Literal.java +++ b/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/DecimalV3Literal.java @@ -24,7 +24,6 @@ import org.apache.doris.nereids.types.DecimalV3Type; import com.google.common.base.Preconditions; -import org.apache.log4j.Logger; import java.math.BigDecimal; import java.math.RoundingMode; @@ -34,8 +33,6 @@ * Literal for DecimalV3 Type */ public class DecimalV3Literal extends FractionalLiteral { - private static final Logger logger = Logger.getLogger(Literal.class); - private final BigDecimal value; public DecimalV3Literal(BigDecimal value) { @@ -57,8 +54,6 @@ public DecimalV3Literal(DecimalV3Type dataType, BigDecimal value) { Objects.requireNonNull(value, "value not be null"); checkPrecisionAndScale(precision, scale, value); BigDecimal adjustedValue = value.scale() < 0 ? value : value.setScale(scale, RoundingMode.HALF_UP); - logger.info("DecimalV3Literal orig bigDecimal: " + value - + ", targetType: " + dataType + ", result big decimal: " + adjustedValue); this.value = Objects.requireNonNull(adjustedValue); } diff --git a/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/Literal.java b/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/Literal.java index 02989a3099ce82..0260ba2e391bf9 100644 --- a/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/Literal.java +++ b/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/Literal.java @@ -52,7 +52,6 @@ import org.apache.doris.qe.SessionVariable; import com.google.common.collect.ImmutableList; -import org.apache.log4j.Logger; import java.math.BigDecimal; import java.math.BigInteger; @@ -70,7 +69,6 @@ */ public abstract class Literal extends Expression implements LeafExpression { - private static final Logger logger = Logger.getLogger(Literal.class); protected final DataType dataType; /** @@ -396,8 +394,6 @@ protected Expression getDecimalLiteral(BigDecimal bigDecimal, DataType targetTyp } BigDecimal result = bigDecimal.setScale(sTarget, RoundingMode.HALF_UP) .round(new MathContext(pTarget, RoundingMode.HALF_UP)); - logger.info("getDecimalLiteral orig bigDecimal: " + bigDecimal - + ", targetType: " + targetType + ", result big decimal: " + result); if (targetType.isDecimalV2Type()) { return new DecimalLiteral((DecimalV2Type) targetType, result); } else {