Skip to content

Commit 5a575c9

Browse files
committed
fix(line): tweak deprecation tip
1 parent 68a151a commit 5a575c9

2 files changed

Lines changed: 9 additions & 3 deletions

File tree

src/chart/line/LineSeries.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,13 +121,15 @@ export interface LineSeriesOption extends SeriesOption<LineStateOption<CallbackD
121121
data?: (LineDataValue | LineDataItemOption)[]
122122

123123
/**
124-
* @deprecated Use `triggerEvent: 'line'` for only line event or `triggerEvent: true` for both line and area event.
124+
* @deprecated
125+
* This option has been deprecated since v6.0.1.
126+
* Use `triggerEvent: 'line'` for only line event or `triggerEvent: true` for both line and area event.
125127
*/
126128
triggerLineEvent?: boolean
127129

128130
/**
129131
* Whether to trigger event when hovering on the line or the area
130-
* @since v6.0.0
132+
* @since v6.0.1
131133
*/
132134
triggerEvent?: boolean | 'line' | 'area'
133135
}

src/chart/line/LineView.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,10 +52,10 @@ import { setStatesStylesFromModel, setStatesFlag, toggleHoverEmphasis, SPECIAL_S
5252
import Model from '../../model/Model';
5353
import { setLabelStyle, getLabelStatesModels, labelInner } from '../../label/labelStyle';
5454
import { getDefaultLabel, getDefaultInterpolatedLabel } from '../helper/labelHelper';
55-
5655
import { getECData } from '../../util/innerStore';
5756
import { createFloat32Array } from '../../util/vendor';
5857
import { convertToColorString } from '../../util/format';
58+
import { warnDeprecated } from '../../util/styleCompat';
5959
import { lerp } from 'zrender/src/tool/color';
6060
import Element from 'zrender/src/Element';
6161

@@ -923,6 +923,10 @@ class LineView extends ChartView {
923923
const triggerEvent = seriesModel.get('triggerEvent');
924924
const triggerLineEvent = seriesModel.get('triggerLineEvent');
925925

926+
if (__DEV__) {
927+
triggerLineEvent && warnDeprecated('triggerLineEvent', 'Use the `triggerEvent` option instead.');
928+
}
929+
926930
const shouldTriggerLineEvent = triggerLineEvent === true || triggerEvent === true || triggerEvent === 'line';
927931
const shouldTriggerAreaEvent = triggerLineEvent === true || triggerEvent === true || triggerEvent === 'area';
928932

0 commit comments

Comments
 (0)