Commit 716a980
committed
Address PR review feedback: cache filter, add null check, add logging
- Implement filter caching using double-checked locking with volatile fields to eliminate race conditions and improve performance
- Add null check before setObjectInputFilter() for defensive programming
- Add INFO logging when filter is configured and WARN logging when not configured to improve security visibility
Addresses review comments by @sboorlagadda on PR #79661 parent 1605e10 commit 716a980
2 files changed
Lines changed: 40 additions & 7 deletions
File tree
- extensions
- geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/filter
- geode-modules/src/main/java/org/apache/geode/modules/util
Lines changed: 37 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
79 | 79 | | |
80 | 80 | | |
81 | 81 | | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
82 | 89 | | |
83 | 90 | | |
84 | 91 | | |
| |||
108 | 115 | | |
109 | 116 | | |
110 | 117 | | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
111 | 146 | | |
112 | 147 | | |
113 | 148 | | |
| |||
145 | 180 | | |
146 | 181 | | |
147 | 182 | | |
148 | | - | |
149 | | - | |
150 | | - | |
151 | | - | |
152 | | - | |
153 | | - | |
| 183 | + | |
| 184 | + | |
154 | 185 | | |
155 | 186 | | |
156 | 187 | | |
| |||
Lines changed: 3 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
43 | | - | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
44 | 46 | | |
45 | 47 | | |
46 | 48 | | |
| |||
0 commit comments