Skip to content

Commit 5ba6d4a

Browse files
committed
optimize: Optimize RocksDB batch query performance
1 parent 9126c80 commit 5ba6d4a

2 files changed

Lines changed: 4 additions & 3 deletions

File tree

hugegraph-server/hugegraph-rocksdb/src/main/java/org/apache/hugegraph/backend/store/rocksdb/RocksDBTable.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import java.util.ArrayList;
2121
import java.util.Collection;
2222
import java.util.Collections;
23+
import java.util.HashSet;
2324
import java.util.Iterator;
2425
import java.util.List;
2526
import java.util.Set;
@@ -180,7 +181,7 @@ protected BackendColumnIterator queryBy(RocksDBSessions.Session session, Query q
180181
// Query by id
181182
if (query.conditionsSize() == 0) {
182183
assert query.idsSize() > 0;
183-
return this.queryByIds(session, query.ids());
184+
return this.getByIds(session, new HashSet<>(query.ids()));
184185
}
185186

186187
// Query by condition (or condition + id)

hugegraph-server/hugegraph-rocksdb/src/main/java/org/apache/hugegraph/backend/store/rocksdb/RocksDBTables.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import java.nio.ByteBuffer;
2121
import java.nio.ByteOrder;
2222
import java.util.Collection;
23+
import java.util.HashSet;
2324
import java.util.List;
2425

2526
import org.apache.hugegraph.backend.id.Id;
@@ -182,8 +183,7 @@ protected BackendColumnIterator queryById(RocksDBSessions.Session session, Id id
182183
@Override
183184
protected BackendColumnIterator queryByIds(RocksDBSessions.Session session,
184185
Collection<Id> ids) {
185-
// TODO: use getByIds() after batch version multi-get is ready
186-
return super.queryByIds(session, ids);
186+
return this.getByIds(session, new HashSet<>(ids));
187187
}
188188
}
189189

0 commit comments

Comments
 (0)