From 3033fa3557ec11d87b9218438a78efb712e4d7f1 Mon Sep 17 00:00:00 2001
From: uros-b <221401595+uros-b@users.noreply.github.com>
Date: Wed, 29 Jul 2026 22:34:11 +0000
Subject: [PATCH] API: Add missing @return Javadoc to fluent/namespace method

---
 api/src/main/java/org/apache/iceberg/ManageSnapshots.java       | 2 ++
 api/src/main/java/org/apache/iceberg/SnapshotUpdate.java        | 1 +
 .../main/java/org/apache/iceberg/catalog/SessionCatalog.java    | 1 +
 .../java/org/apache/iceberg/catalog/SupportsNamespaces.java     | 2 ++
 4 files changed, 6 insertions(+)

diff --git a/api/src/main/java/org/apache/iceberg/ManageSnapshots.java b/api/src/main/java/org/apache/iceberg/ManageSnapshots.java
index 007bf94aefcd..5774c0d7f5ac 100644
--- a/api/src/main/java/org/apache/iceberg/ManageSnapshots.java
+++ b/api/src/main/java/org/apache/iceberg/ManageSnapshots.java
@@ -66,6 +66,7 @@ public interface ManageSnapshots extends PendingUpdate<Snapshot> {
    *
    * @param snapshotId long id of snapshot id to roll back table to. Must be an ancestor of the
    *     current snapshot
+   * @return this for method chaining
    * @throws IllegalArgumentException If the table has no snapshot with the given id
    * @throws ValidationException If given snapshot id is not an ancestor of the current state
    */
@@ -130,6 +131,7 @@ default ManageSnapshots createBranch(String name) {
    *
    * @param name name of branch to rename
    * @param newName the desired new name of the branch
+   * @return this for method chaining
    * @throws IllegalArgumentException if the branch to rename does not exist or if there is already
    *     a branch with the same name as the desired new name.
    */
diff --git a/api/src/main/java/org/apache/iceberg/SnapshotUpdate.java b/api/src/main/java/org/apache/iceberg/SnapshotUpdate.java
index b57607cbf75c..9ce946c0a055 100644
--- a/api/src/main/java/org/apache/iceberg/SnapshotUpdate.java
+++ b/api/src/main/java/org/apache/iceberg/SnapshotUpdate.java
@@ -80,6 +80,7 @@ default ThisT writeManifestsWith(ExecutorService executorService, int parallelis
    * Perform operations on a particular branch
    *
    * @param branch which is name of SnapshotRef of type branch.
+   * @return this for method chaining
    */
   default ThisT toBranch(String branch) {
     throw new UnsupportedOperationException(
diff --git a/api/src/main/java/org/apache/iceberg/catalog/SessionCatalog.java b/api/src/main/java/org/apache/iceberg/catalog/SessionCatalog.java
index b54570485357..ac6a1114eb81 100644
--- a/api/src/main/java/org/apache/iceberg/catalog/SessionCatalog.java
+++ b/api/src/main/java/org/apache/iceberg/catalog/SessionCatalog.java
@@ -363,6 +363,7 @@ default List<Namespace> listNamespaces(SessionContext context) {
    * @param namespace a {@link Namespace namespace}
    * @param updates properties to set for the namespace
    * @param removals properties to remove from the namespace
+   * @return true if the namespace metadata was successfully updated, false otherwise
    * @throws NoSuchNamespaceException If the namespace does not exist (optional)
    * @throws UnsupportedOperationException If namespace properties are not supported
    */
diff --git a/api/src/main/java/org/apache/iceberg/catalog/SupportsNamespaces.java b/api/src/main/java/org/apache/iceberg/catalog/SupportsNamespaces.java
index 7c3af5fe5745..fda96a324e9e 100644
--- a/api/src/main/java/org/apache/iceberg/catalog/SupportsNamespaces.java
+++ b/api/src/main/java/org/apache/iceberg/catalog/SupportsNamespaces.java
@@ -129,6 +129,7 @@ default List<Namespace> listNamespaces() {
    *
    * @param namespace a namespace. {@link Namespace}
    * @param properties a collection of metadata to apply to the namespace
+   * @return true if the properties were successfully set, false otherwise
    * @throws NoSuchNamespaceException If the namespace does not exist (optional)
    * @throws UnsupportedOperationException If namespace properties are not supported
    */
@@ -142,6 +143,7 @@ boolean setProperties(Namespace namespace, Map<String, String> properties)
    *
    * @param namespace a namespace. {@link Namespace}
    * @param properties a collection of metadata to apply to the namespace
+   * @return true if the properties were successfully removed, false otherwise
    * @throws NoSuchNamespaceException If the namespace does not exist (optional)
    * @throws UnsupportedOperationException If namespace properties are not supported
    */