Skip to content

Method "create_node" overrides class "NodeDriver" in an incompatible manner in multiple drivers #2133

@ChihweiLHBird

Description

@ChihweiLHBird

Summary

Most drivers create_node function is not compatible with the base class' function and causing some IDE warnings.
For example, in azure:

Method "create_node" overrides class "NodeDriver" in an incompatible manner
  Parameter 5 name mismatch: base parameter is named "location", override parameter is named "ex_cloud_service_name"
  Parameter 6 name mismatch: base parameter is named "auth", override parameter is named "ex_storage_service_name" Pylance (reportIncompatibleMethodOverride)

Fixing all of them will definitely introduce breaking changes. So more discussion would be needed apparently.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions