Skip to content

[LIVY-663][API] exposing job id and session id in livy client#228

Open
grarkydev wants to merge 2 commits into
apache:masterfrom
grarkydev:LIVY-663
Open

[LIVY-663][API] exposing job id and session id in livy client#228
grarkydev wants to merge 2 commits into
apache:masterfrom
grarkydev:LIVY-663

Conversation

@grarkydev

Copy link
Copy Markdown

What changes were proposed in this pull request?

Exposing job id and session id in livy client.

This change will make recognizing of job state change events' source possible.

@codecov-io

codecov-io commented Sep 9, 2019

Copy link
Copy Markdown

Codecov Report

Merging #228 into master will decrease coverage by <.01%.
The diff coverage is 71.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #228      +/-   ##
============================================
- Coverage     68.12%   68.12%   -0.01%     
- Complexity      960      963       +3     
============================================
  Files           104      104              
  Lines          5946     5951       +5     
  Branches        899      899              
============================================
+ Hits           4051     4054       +3     
- Misses         1314     1316       +2     
  Partials        581      581
Impacted Files Coverage Δ Complexity Δ
api/src/main/java/org/apache/livy/JobHandle.java 100% <ø> (ø) 0 <0> (ø) ⬇️
...c/src/main/java/org/apache/livy/rsc/RSCClient.java 73.05% <0%> (-0.45%) 20 <0> (ø)
...ala/org/apache/livy/scalaapi/LivyScalaClient.scala 83.87% <100%> (+0.53%) 8 <1> (+1) ⬆️
...n/java/org/apache/livy/client/http/HttpClient.java 85.48% <100%> (ø) 15 <1> (ø) ⬇️
...c/main/java/org/apache/livy/rsc/JobHandleImpl.java 74.07% <100%> (+0.99%) 8 <1> (+1) ⬆️
...ava/org/apache/livy/client/http/JobHandleImpl.java 75.45% <100%> (+0.22%) 14 <1> (+1) ⬆️
...cala/org/apache/livy/scalaapi/ScalaJobHandle.scala 51.42% <50%> (-1.52%) 8 <1> (+1)
...a/org/apache/livy/server/ThriftServerFactory.scala 100% <0%> (ø) 0% <0%> (ø) ⬇️
...main/scala/org/apache/livy/server/LivyServer.scala 33.03% <0%> (ø) 11% <0%> (ø) ⬇️
...rc/main/scala/org/apache/livy/utils/SparkApp.scala 76% <0%> (ø) 1% <0%> (ø) ⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4ab5ef...6ff7fbf. Read the comment docs.

@jerryshao

Copy link
Copy Markdown
Contributor

I think such APIs should also be added in Scala and Python Client. Also would you please add some unit tests, thanks.

@celadari

celadari commented Aug 2, 2020

Copy link
Copy Markdown

any updates on this ?

@grarkydev

Copy link
Copy Markdown
Author

@celadari in my opinion it is ready to be merged
@jerryshao should anything else be fixed/updated/changed for acceptance?

@github-actions

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has had no activity for at least 3 months. If you are still working on this change or plan to move it forward, please leave a comment or push a new commit so we know to keep it open. Otherwise, this PR will be closed automatically in about one month. Thank you for your contribution to Apache Livy!

@github-actions github-actions Bot added the stale label May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants