From f79bc003a6d135941a831ab5ae5400967abd06f6 Mon Sep 17 00:00:00 2001 From: Elliotte Rusty Harold Date: Sun, 20 Oct 2024 17:16:01 -0400 Subject: [PATCH 1/3] Don't print stack trace from correctly functioning code --- .../plugins/artifact/buildinfo/ReferenceBuildinfoUtil.java | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/main/java/org/apache/maven/plugins/artifact/buildinfo/ReferenceBuildinfoUtil.java b/src/main/java/org/apache/maven/plugins/artifact/buildinfo/ReferenceBuildinfoUtil.java index e7892a0..f4fbb23 100644 --- a/src/main/java/org/apache/maven/plugins/artifact/buildinfo/ReferenceBuildinfoUtil.java +++ b/src/main/java/org/apache/maven/plugins/artifact/buildinfo/ReferenceBuildinfoUtil.java @@ -37,6 +37,7 @@ import java.util.jar.JarFile; import java.util.jar.Manifest; import java.util.zip.ZipEntry; +import java.util.zip.ZipException; import org.apache.commons.io.IOUtils; import org.apache.maven.plugin.MojoExecutionException; @@ -213,8 +214,10 @@ private ReproducibleEnv extractEnv(File file, Artifact artifact) { } else { log.warn("no MANIFEST.MF found in jar " + file); } - } catch (IOException e) { - log.warn("unable to open jar file " + file, e); + } catch (ZipException e) { + log.warn("Corrupt jar file " + file + "\n" + e.getMessage()); + } catch (IOException e) { + log.warn("unable to read jar file " + file + "\n" + e.getMessage()); } return null; } From c7956e0b4eeb4dd9e7f0eeabfb5a57da7aebab87 Mon Sep 17 00:00:00 2001 From: Elliotte Rusty Harold Date: Sun, 20 Oct 2024 17:17:17 -0400 Subject: [PATCH 2/3] spotless --- .../plugins/artifact/buildinfo/ReferenceBuildinfoUtil.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/org/apache/maven/plugins/artifact/buildinfo/ReferenceBuildinfoUtil.java b/src/main/java/org/apache/maven/plugins/artifact/buildinfo/ReferenceBuildinfoUtil.java index f4fbb23..e98ddb7 100644 --- a/src/main/java/org/apache/maven/plugins/artifact/buildinfo/ReferenceBuildinfoUtil.java +++ b/src/main/java/org/apache/maven/plugins/artifact/buildinfo/ReferenceBuildinfoUtil.java @@ -216,7 +216,7 @@ private ReproducibleEnv extractEnv(File file, Artifact artifact) { } } catch (ZipException e) { log.warn("Corrupt jar file " + file + "\n" + e.getMessage()); - } catch (IOException e) { + } catch (IOException e) { log.warn("unable to read jar file " + file + "\n" + e.getMessage()); } return null; From a8e444e9bc0943d49184a4ef9e88a9e931d85f48 Mon Sep 17 00:00:00 2001 From: Elliotte Rusty Harold Date: Tue, 30 Sep 2025 07:08:14 -0400 Subject: [PATCH 3/3] add exception class name --- .../plugins/artifact/buildinfo/ReferenceBuildinfoUtil.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/main/java/org/apache/maven/plugins/artifact/buildinfo/ReferenceBuildinfoUtil.java b/src/main/java/org/apache/maven/plugins/artifact/buildinfo/ReferenceBuildinfoUtil.java index e42661d..15842b4 100644 --- a/src/main/java/org/apache/maven/plugins/artifact/buildinfo/ReferenceBuildinfoUtil.java +++ b/src/main/java/org/apache/maven/plugins/artifact/buildinfo/ReferenceBuildinfoUtil.java @@ -214,7 +214,8 @@ private ReproducibleEnv extractEnv(File file, Artifact artifact) { } catch (ZipException e) { log.warn("Corrupt jar file " + file + "\n" + e.getMessage()); } catch (IOException e) { - log.warn("unable to read jar file " + file + "\n" + e.getMessage()); + log.warn("unable to read jar file " + file + "\n due to " + + e.getClass().getName() + "\n" + e.getMessage()); } return null; }