From a0be3456cb2abd9bbaf809820e0150f20bd87cdf Mon Sep 17 00:00:00 2001 From: Tamas Cservenak Date: Thu, 4 Jun 2026 13:50:07 +0200 Subject: [PATCH] Disable IPC lock tests on Windows The are unstable and flakey and just cause noise. Am unsure how much are they used anyway. Until someone on Windows fixes them, they are disabled. --- .../test/java/org/eclipse/aether/named/ipc/IpcAdapterIT.java | 3 +++ .../java/org/eclipse/aether/named/ipc/IpcAdapterNoForkIT.java | 3 +++ .../org/eclipse/aether/named/ipc/IpcNamedLockFactoryIT.java | 3 +++ 3 files changed, 9 insertions(+) diff --git a/maven-resolver-named-locks-ipc/src/test/java/org/eclipse/aether/named/ipc/IpcAdapterIT.java b/maven-resolver-named-locks-ipc/src/test/java/org/eclipse/aether/named/ipc/IpcAdapterIT.java index a4b4d48c4..77232cf4e 100644 --- a/maven-resolver-named-locks-ipc/src/test/java/org/eclipse/aether/named/ipc/IpcAdapterIT.java +++ b/maven-resolver-named-locks-ipc/src/test/java/org/eclipse/aether/named/ipc/IpcAdapterIT.java @@ -19,7 +19,10 @@ package org.eclipse.aether.named.ipc; import org.junit.jupiter.api.BeforeAll; +import org.junit.jupiter.api.condition.DisabledOnOs; +import org.junit.jupiter.api.condition.OS; +@DisabledOnOs(OS.WINDOWS) public class IpcAdapterIT extends NamedLockFactoryAdapterTestSupport { @BeforeAll static void createNamedLockFactory() { diff --git a/maven-resolver-named-locks-ipc/src/test/java/org/eclipse/aether/named/ipc/IpcAdapterNoForkIT.java b/maven-resolver-named-locks-ipc/src/test/java/org/eclipse/aether/named/ipc/IpcAdapterNoForkIT.java index bf07ce9ba..30ee44c0d 100644 --- a/maven-resolver-named-locks-ipc/src/test/java/org/eclipse/aether/named/ipc/IpcAdapterNoForkIT.java +++ b/maven-resolver-named-locks-ipc/src/test/java/org/eclipse/aether/named/ipc/IpcAdapterNoForkIT.java @@ -20,7 +20,10 @@ import org.junit.jupiter.api.AfterAll; import org.junit.jupiter.api.BeforeAll; +import org.junit.jupiter.api.condition.DisabledOnOs; +import org.junit.jupiter.api.condition.OS; +@DisabledOnOs(OS.WINDOWS) public class IpcAdapterNoForkIT extends NamedLockFactoryAdapterTestSupport { @BeforeAll static void createNamedLockFactory() { diff --git a/maven-resolver-named-locks-ipc/src/test/java/org/eclipse/aether/named/ipc/IpcNamedLockFactoryIT.java b/maven-resolver-named-locks-ipc/src/test/java/org/eclipse/aether/named/ipc/IpcNamedLockFactoryIT.java index 62404f8c7..b3a22d2e8 100644 --- a/maven-resolver-named-locks-ipc/src/test/java/org/eclipse/aether/named/ipc/IpcNamedLockFactoryIT.java +++ b/maven-resolver-named-locks-ipc/src/test/java/org/eclipse/aether/named/ipc/IpcNamedLockFactoryIT.java @@ -19,7 +19,10 @@ package org.eclipse.aether.named.ipc; import org.junit.jupiter.api.BeforeAll; +import org.junit.jupiter.api.condition.DisabledOnOs; +import org.junit.jupiter.api.condition.OS; +@DisabledOnOs(OS.WINDOWS) public class IpcNamedLockFactoryIT extends NamedLockFactoryTestSupport { @BeforeAll static void createNamedLockFactory() {