Skip to content

Commit 106e2cd

Browse files
authored
chore: fix grammar and spelling (#101)
1 parent fd3863c commit 106e2cd

4 files changed

Lines changed: 7 additions & 7 deletions

File tree

CONTRIBUTING.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121

2222
# Contributing to Apache OpenWhisk
2323

24-
Anyone can contribute to the OpenWhisk project and we welcome your contributions.
24+
Anyone can contribute to the OpenWhisk project, and we welcome your contributions.
2525

2626
There are multiple ways to contribute: report bugs, improve the docs, and
2727
contribute code, but you must follow these prerequisites and guidelines:
@@ -50,7 +50,7 @@ Please raise any bug reports or enhancement requests on the respective project r
5050
list to see if your issue has already been raised.
5151

5252
A good bug report is one that make it easy for us to understand what you were trying to do and what went wrong.
53-
Provide as much context as possible so we can try to recreate the issue.
53+
Provide as much context as possible, so we can try to recreate the issue.
5454

5555
A good enhancement request comes with an explanation of what you are trying to do and how that enhancement would help you.
5656

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ docker tag whisk/php7.3Action $user_prefix/action-php-v7.3
117117
docker push $user_prefix/action-php-v7.3
118118
```
119119

120-
Then create the action using your the image from dockerhub
120+
Then create the action using your image from dockerhub
121121
```
122122
wsk action update myAction myAction.php --docker $user_prefix/action-php-v8.0
123123
```
@@ -146,7 +146,7 @@ Using gradle to run some tests
146146
```
147147
Using IntelliJ:
148148
- Import project as gradle project.
149-
- Make sure working directory is root of the project/repo
149+
- Make sure the working directory is root of the project/repo
150150
- Add the following Java VM properties in ScalaTests Run Configuration, easiest is to change the Defaults for all ScalaTests to use this VM properties
151151
```
152152
-Dhttp.proxyHost=localhost

gradle/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,14 +41,14 @@ Project level options that can be used on `distDocker`:
4141

4242
### Test
4343

44-
To run tests one uses the `test` task. OpenWhisk consolidates tests into a single `tests` project. Hence the command to run all tests is `gradle :tests:test`.
44+
To run tests one uses the `test` task. OpenWhisk consolidates tests into a single `tests` project. Hence, the command to run all tests is `gradle :tests:test`.
4545

4646
It is possible to run specific tests using [Gradle testfilters](https://docs.gradle.org/current/userguide/java_plugin.html#test_filtering). For example `gradle :tests:test --tests "your.package.name.TestClass.evenMethodName"`. Wildcard `*` may be used anywhere.
4747

4848
## Build your own `build.gradle`
4949
In Gradle, most of the tasks we use are default tasks provided by plugins in Gradle. The [`scala` Plugin](https://docs.gradle.org/current/userguide/scala_plugin.html) for example includes tasks, that are needed to build Scala projects. Moreover, Gradle is aware of *Applications*. The [`application` Plugin](https://docs.gradle.org/current/userguide/application_plugin.html) provides tasks that are required to distribute a self-contained application. When `application` and `scala` are used in conjunction, they hook into each other and provide the tasks needed to distribute a Scala application. `distTar` for example compiles the Scala code, creates a jar containing the compiled classes and resources and creates a Tarball including that jar and all of its dependencies (defined in the dependencies section of `build.gradle`). It also creates a start-script which correctly sets the classpath for all those dependencies and starts the app.
5050

51-
In OpenWhisk, we want to distribute our application via Docker images. Hence we wrote a "plugin" that creates the task `distDocker`. That task will build an image from the `Dockerfile` that is located next to the `build.gradle` it is called from, for example Controller's `Dockerfile` and `build.gradle` are both located at `core/controller`.
51+
In OpenWhisk, we want to distribute our application via Docker images. Hence, we wrote a "plugin" that creates the task `distDocker`. That task will build an image from the `Dockerfile` that is located next to the `build.gradle` it is called from, for example Controller's `Dockerfile` and `build.gradle` are both located at `core/controller`.
5252

5353
If you want to create a new `build.gradle` for your component, simply put the `Dockerfile` right next to it and include `docker.gradle` by using
5454

tests/src/test/scala/runtime/actionContainers/Php7ActionContainerTests.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,7 @@ abstract class Php7ActionContainerTests extends BasicActionRunnerTests with WskA
263263
})
264264
}
265265

266-
it should "suport returning a stdClass" in {
266+
it should "support returning a stdClass" in {
267267
val (out, err) = withPhp7Container { c =>
268268
val code = """
269269
| <?php

0 commit comments

Comments
 (0)