Bump C++ client to 4.0.0 (#273)

Author: BewareMyPower

CMakeLists.txt

@@ -48,7 +48,7 @@ message(STATUS "PULSAR_LIBRARY: ${PULSAR_LIBRARY}")
 find_path(PULSAR_INCLUDE pulsar/Client.h)
 message(STATUS "PULSAR_INCLUDE: ${PULSAR_INCLUDE}")
 
-SET(CMAKE_CXX_STANDARD 11)
+SET(CMAKE_CXX_STANDARD 17)
 
 find_package (Python3 REQUIRED COMPONENTS Development.Module)
 MESSAGE(STATUS "PYTHON: " ${Python3_VERSION} " - " ${Python3_INCLUDE_DIRS})

dependencies.yaml

@@ -17,7 +17,7 @@
 # under the License.
 #
 
-pulsar-cpp: 3.8.0
+pulsar-cpp: 4.0.0
 pybind11: 2.10.1
 # The OpenSSL dependency is only used when building Python from source
 openssl: 1.1.1q

tests/custom_logger_test.py

@@ -21,6 +21,7 @@
 from unittest import TestCase, main
 import asyncio
 import logging
+import threading
 from pulsar import Client
 
 class CustomLoggingTest(TestCase):
@@ -49,6 +50,35 @@ async def async_get(value):
 
         client.close()
 
+    def test_logger_thread_leaks(self):
+        def _do_connect(close):
+            logger = logging.getLogger(str(threading.current_thread().ident))
+            logger.setLevel(logging.INFO)
+            client = Client(
+                service_url="pulsar://localhost:6650",
+                io_threads=4,
+                message_listener_threads=4,
+                operation_timeout_seconds=1,
+                log_conf_file_path=None,
+                authentication=None,
+                logger=logger,
+            )
+            client.get_topic_partitions("persistent://public/default/partitioned_topic_name_test")
+            if close:
+                client.close()
+
+        for should_close in (True, False):
+            self.assertEqual(threading.active_count(), 1, "Explicit close: {}; baseline is 1 thread".format(should_close))
+            _do_connect(should_close)
+            self.assertEqual(threading.active_count(), 1, "Explicit close: {}; synchronous connect doesn't leak threads".format(should_close))
+            threads = []
+            for _ in range(10):
+                threads.append(threading.Thread(target=_do_connect, args=(should_close)))
+                threads[-1].start()
+            for thread in threads:
+                thread.join()
+            assert threading.active_count() == 1, "Explicit close: {}; threaded connect in parallel doesn't leak threads".format(should_close)
+
 if __name__ == '__main__':
     logging.basicConfig(level=logging.DEBUG)
     main()

tests/pulsar_test.py

@@ -20,8 +20,6 @@
 
 
 import random
-import threading
-import logging
 from typing import Optional
 from unittest import TestCase, main
 import time
@@ -1529,34 +1527,6 @@ def test_json_schema_encode(self):
         self.assertEqual(first_encode, second_encode)
 
 
-    def test_logger_thread_leaks(self):
-        def _do_connect(close):
-            logger = logging.getLogger(str(threading.current_thread().ident))
-            logger.setLevel(logging.INFO)
-            client = pulsar.Client(
-                service_url="pulsar://localhost:6650",
-                io_threads=4,
-                message_listener_threads=4,
-                operation_timeout_seconds=1,
-                log_conf_file_path=None,
-                authentication=None,
-                logger=logger,
-            )
-            client.get_topic_partitions("persistent://public/default/partitioned_topic_name_test")
-            if close:
-                client.close()
-
-        for should_close in (True, False):
-            self.assertEqual(threading.active_count(), 1, "Explicit close: {}; baseline is 1 thread".format(should_close))
-            _do_connect(should_close)
-            self.assertEqual(threading.active_count(), 1, "Explicit close: {}; synchronous connect doesn't leak threads".format(should_close))
-            threads = []
-            for _ in range(10):
-                threads.append(threading.Thread(target=_do_connect, args=(should_close)))
-                threads[-1].start()
-            for thread in threads:
-                thread.join()
-            assert threading.active_count() == 1, "Explicit close: {}; threaded connect in parallel doesn't leak threads".format(should_close)
 
     def test_chunking(self):
         client = Client(self.serviceUrl)