Skip to content

Commit 8c53417

Browse files
committed
fix: remove default propagation_exclude_ports from agent.config
Move the PROPAGATION_EXCLUDE_PORTS=8123 config from the global agent.config default to the clickhouse-0.3.1 E2E test scenario only, as requested in code review.
1 parent aad37d2 commit 8c53417

2 files changed

Lines changed: 1 addition & 2 deletions

File tree

apm-sniffer/config/agent.config

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -220,8 +220,6 @@ plugin.tomcat.collect_http_params=${SW_PLUGIN_TOMCAT_COLLECT_HTTP_PARAMS:false}
220220
plugin.springmvc.collect_http_params=${SW_PLUGIN_SPRINGMVC_COLLECT_HTTP_PARAMS:false}
221221
# This config item controls that whether the HttpClient plugin should collect the parameters of the request
222222
plugin.httpclient.collect_http_params=${SW_PLUGIN_HTTPCLIENT_COLLECT_HTTP_PARAMS:false}
223-
# Comma-separated list of destination ports whose outbound HTTP requests will be completely skipped by the httpclient-4.x interceptor (no exit span created, no sw8 headers injected). Default: 8123 (ClickHouse HTTP interface).
224-
plugin.httpclient.propagation_exclude_ports=${SW_PLUGIN_HTTPCLIENT_PROPAGATION_EXCLUDE_PORTS:8123}
225223
# When `COLLECT_HTTP_PARAMS` is enabled, how many characters to keep and send to the OAP backend, use negative values to keep and send the complete parameters, NB. this config item is added for the sake of performance.
226224
plugin.http.http_params_length_threshold=${SW_PLUGIN_HTTP_HTTP_PARAMS_LENGTH_THRESHOLD:1024}
227225
# When `include_http_headers` declares header names, this threshold controls the length limitation of all header values. use negative values to keep and send the complete headers. Note. this config item is added for the sake of performance.

test/plugin/scenarios/clickhouse-0.3.1-scenario/configuration.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ healthCheck: http://localhost:8080/clickhouse-scenario/case/healthCheck
2020
startScript: ./bin/startup.sh
2121
environment:
2222
- SW_JDBC_TRACE_SQL_PARAMETERS=true
23+
- SW_PLUGIN_HTTPCLIENT_PROPAGATION_EXCLUDE_PORTS=8123
2324
depends_on:
2425
- clickhouse-server
2526
dependencies:

0 commit comments

Comments
 (0)