Skip to content

Commit 419885b

Browse files
committed
OpenSSL 3.0.0 is minimum version so hard code OPENSSL_NEW_LIBS=1
1 parent ca8a78b commit 419885b

4 files changed

Lines changed: 6 additions & 8 deletions

File tree

.github/workflows/makefile.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ jobs:
8181
call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\Tools\VsDevCmd.bat" -arch=${{ matrix.arch }}
8282
cd native
8383
echo "Building for ${{ matrix.build-arch }}"
84-
nmake -f NMAKEmakefile CPU=${{ matrix.build-arch }} WITH_APR=C:\APR WITH_OPENSSL=C:\OPENSSL APR_DECLARE_STATIC=1 STATIC_CRT=Hybrid OPENSSL_NEW_LIBS=1
84+
nmake -f NMAKEmakefile CPU=${{ matrix.build-arch }} WITH_APR=C:\APR WITH_OPENSSL=C:\OPENSSL APR_DECLARE_STATIC=1 STATIC_CRT=Hybrid
8585
- uses: actions/upload-artifact@v4
8686
with:
8787
name: windows-artifact

native/BUILDING

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -165,10 +165,10 @@ Windows
165165
>set JAVA_HOME=C:\java\21.0.7-tem
166166

167167
> "c:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvars32.bat"
168-
> nmake -f NMAKEMakefile WITH_APR=C:\deps-x86\apr-%APR_VER% WITH_OPENSSL=C:\deps-x86\openssl-%OPENSSL_VER% CPU=X86 APR_DECLARE_STATIC=1 STATIC_CRT=Hybrid OPENSSL_NEW_LIBS=1
168+
> nmake -f NMAKEMakefile WITH_APR=C:\deps-x86\apr-%APR_VER% WITH_OPENSSL=C:\deps-x86\openssl-%OPENSSL_VER% CPU=X86 APR_DECLARE_STATIC=1 STATIC_CRT=Hybrid
169169

170170
> "c:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvars64.bat"
171-
> nmake -f NMAKEMakefile WITH_APR=C:\deps-x64\apr-%APR_VER% WITH_OPENSSL=C:\deps-x64\openssl-%OPENSSL_VER% CPU=X64 APR_DECLARE_STATIC=1 STATIC_CRT=Hybrid OPENSSL_NEW_LIBS=1
171+
> nmake -f NMAKEMakefile WITH_APR=C:\deps-x64\apr-%APR_VER% WITH_OPENSSL=C:\deps-x64\openssl-%OPENSSL_VER% CPU=X64 APR_DECLARE_STATIC=1 STATIC_CRT=Hybrid
172172

173173
Tomcat Native Connector DLLs may then be found in native\WIN7_*_DLL_RELEASE
174174

native/NMAKEmakefile

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
# Usage:
2020
# APR_DECLARE_STATIC=1 Use static version of the APR
2121
# DISABLE_OCSP=1 Disable OpenSSL OCSP code
22-
# OPENSSL_NEW_LIBS=1 Use new OpenSSL lib file names
2322
# DEBUG=1 Build DEBUG version of TCN
2423
# STATIC_CRT=Hybrid Build using the 'Hybrid CRT' technique
2524
#
@@ -76,11 +75,7 @@ LIBS = $(LIBS) user32.lib gdi32.lib $(APR_LIB)
7675
LIBS = $(LIBS) libeayfips32.lib libeaycompat32.lib ssleay32.lib
7776
LFLAGS = $(LFLAGS) /NODEFAULTLIB:LIBCMT
7877
!ELSE
79-
!IF DEFINED(OPENSSL_NEW_LIBS)
8078
LIBS = $(LIBS) libssl.lib libcrypto.lib crypt32.lib
81-
!ELSE
82-
LIBS = $(LIBS) libeay32.lib ssleay32.lib
83-
!ENDIF
8479
!ENDIF
8580

8681
CFLAGS = $(CFLAGS) -DZLIB_WINAPI -DNO_IDEA -DNO_RC5 -DNO_MDC2 -DOPENSSL_NO_IDEA \

xdocs/miscellaneous/changelog.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,9 @@
6161
connections using TLS 1.2 and earlier. Pull request provided by gastush.
6262
(markt)
6363
</add>
64+
<update>
65+
Remove out of date options from make file. (markt)
66+
</update>
6467
</changelog>
6568
</section>
6669
<section name="Changes in 2.0.9">

0 commit comments

Comments
 (0)