Skip to content

Commit 9bb5ea3

Browse files
committed
fix: address PR review comments
- Update README version badge to 0.17.48 - Add port range validation for autoAssignNodePort: fail if port/tlsPort is outside 30000-32767 when autoAssignNodePort is true
1 parent 9317dcb commit 9bb5ea3

2 files changed

Lines changed: 9 additions & 1 deletion

File tree

charts/api7/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# api7ee3
22

3-
![Version: 0.17.47](https://img.shields.io/badge/Version-0.17.47-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 3.9.7](https://img.shields.io/badge/AppVersion-3.9.7-informational?style=flat-square)
3+
![Version: 0.17.48](https://img.shields.io/badge/Version-0.17.48-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 3.9.7](https://img.shields.io/badge/AppVersion-3.9.7-informational?style=flat-square)
44

55
A Helm chart for Kubernetes
66

charts/api7/templates/dp-manager-service.yaml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,14 @@ metadata:
1111
{{- end }}
1212
spec:
1313
type: {{ .Values.dp_manager_service.type }}
14+
{{- if and (eq .Values.dp_manager_service.type "NodePort") .Values.dp_manager_service.autoAssignNodePort }}
15+
{{- if or (lt (int .Values.dp_manager_service.port) 30000) (gt (int .Values.dp_manager_service.port) 32767) }}
16+
{{- fail (printf "dp_manager_service.port (%d) must be between 30000 and 32767 when autoAssignNodePort is true" (int .Values.dp_manager_service.port)) }}
17+
{{- end }}
18+
{{- if or (lt (int .Values.dp_manager_service.tlsPort) 30000) (gt (int .Values.dp_manager_service.tlsPort) 32767) }}
19+
{{- fail (printf "dp_manager_service.tlsPort (%d) must be between 30000 and 32767 when autoAssignNodePort is true" (int .Values.dp_manager_service.tlsPort)) }}
20+
{{- end }}
21+
{{- end }}
1422
{{- if .Values.dp_manager_service.loadBalancerClass }}
1523
loadBalancerClass: {{ .Values.dp_manager_service.loadBalancerClass }}
1624
{{- end }}

0 commit comments

Comments
 (0)