Skip to content

Commit 03f645a

Browse files
committed
init locked secret name/namespace when undefined
1 parent 6aea20c commit 03f645a

2 files changed

Lines changed: 7 additions & 5 deletions

File tree

common/secret.go

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,14 +46,16 @@ func GetSecret(client client.Client, name string, ns string) (*LockedBufferSecre
4646
secret := &corev1.Secret{}
4747
secret.Name = name
4848
secret.Namespace = ns
49-
err := client.Get(context.TODO(), types.NamespacedName{Name: name, Namespace: ns}, secret)
50-
if err != nil {
51-
return nil, err
52-
}
5349

5450
lockedSecret := &LockedBufferSecret{}
5551
lockedSecret.TypeMeta = secret.TypeMeta
5652
lockedSecret.ObjectMeta = secret.ObjectMeta
53+
54+
err := client.Get(context.TODO(), types.NamespacedName{Name: name, Namespace: ns}, secret)
55+
if err != nil {
56+
return lockedSecret, err
57+
}
58+
5759
if lockedSecret.LockedData == nil {
5860
lockedSecret.LockedData = SecretMap{}
5961
}

utils/service_binding_reconciler.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ func (r *ReconcilerBase) reconcileExpose(ba common.BaseComponent) error {
3030
mObj := ba.(metav1.Object)
3131
bindingSecret, err := common.GetSecret(r.GetClient(), getExposeBindingSecretName(ba), mObj.GetNamespace())
3232
defer bindingSecret.Destroy()
33-
if err != nil {
33+
if client.IgnoreNotFound(err) != nil {
3434
return err
3535
}
3636

0 commit comments

Comments
 (0)