Remove unsafe destroy on LockedData attribute

Author: kabicin

utils/service_binding_reconciler.go

@@ -128,7 +128,7 @@ func (r *ReconcilerBase) applyDefaultValuesToExpose(secret *common.LockedBufferS
 
 	if _, found = secretData["certificates"]; !found && ba.GetStatus().GetReferences()[common.StatusReferenceCertSecretName] != "" {
 		certSecret, err := common.GetSecret(r.GetClient(), ba.GetStatus().GetReferences()[common.StatusReferenceCertSecretName], mObj.GetNamespace())
-		defer certSecret.LockedData.Destroy()
+		defer certSecret.Destroy()
 		if err == nil {
 			caCert, _ := certSecret.LockedData.Get("ca.crt")
 			tlsCrt, _ := certSecret.LockedData.Get("tls.crt")

utils/utils.go

@@ -1158,8 +1158,7 @@ func ValidatePrometheusMonitoringEndpoints(ba common.BaseComponent, client clien
 			}
 			// Error if any Secret is specified but does not exist
 			for _, secretName := range secretNames {
-				secret, err := common.GetSecret(client, secretName, namespace)
-				secret.LockedData.Destroy()
+				err := common.CheckSecret(client, secretName, namespace)
 				if err != nil {
 					errorMessage := fmt.Sprintf("Could not find Secret '%s' in this namespace.", secretName)
 					return errors.New(errorMessage)