Skip to content

[drift] CLI surface changed, consumers need update #17

Description

@areales

Drift Detection Report

Comparing bbdata's live source against downstream consumer expectations (scout-app, ai-baseball-data-analyst).

❌ Query Templates: Count Mismatch

Current state: bbdata has 22 query templates registered in src/templates/queries/index.ts

  • Imports: pitcher-arsenal, pitcher-velocity-trend, pitcher-handedness-splits, hitter-batted-ball, hitter-vs-pitch-type, hitter-hot-cold-zones, hitter-handedness-splits, matchup-pitcher-vs-hitter, matchup-situational, leaderboard-custom, leaderboard-comparison, trend-rolling-average, trend-year-over-year, pitcher-rolling-trend, pitcher-raw-pitches, hitter-raw-bip, hitter-zone-grid, pitcher-recent-form, pitcher-by-count, pitcher-tto, pitcher-season-profile, hitter-season-profile

Consumer expectation: ai-baseball-data-analyst skill expects 21 query templates

  • File: ../ai-baseball-data-analyst/skills/query-data/SKILL.md
  • Impact: Skill documentation is now out of sync with bbdata's actual template registry

⚠️ Report Template Count Comment: Inconsistency

Current state: src/templates/reports/registry.ts line 53 says:

// --- Register all 12 report templates ---

Actual registration: 13 report templates are registered:

  1. pro-pitcher-eval
  2. pro-hitter-eval
  3. relief-pitcher-quick
  4. college-pitcher-draft
  5. college-hitter-draft
  6. hs-prospect
  7. advance-sp
  8. advance-lineup
  9. dev-progress
  10. post-promotion
  11. trade-target-onepager
  12. draft-board-card
  13. draft-board-card-pitcher

Consumer expectation: Both scout-app and ai-baseball-data-analyst expect 13 report templates ✓ (actual count matches)

  • Impact: The inline comment is misleading but the actual template count is correct.

✅ Verified (No Drift)

  • CLI flags (query): All expected flags present (--player, --players, --season, --format, --stat, --min-ip, --min-pa, --top, --pitch-type, --seasons, --source)
  • CLI flags (report): All expected flags present (--player, --season, --audience, --format, --validate)
  • Audience values: All expected values present (coach, gm, scout, analyst)
  • JSON envelope (query): All expected meta fields present (source, cached, queryTimeMs, season, sampleSize)

Recommended Actions

  1. For ai-baseball-data-analyst team: Update skills/query-data/SKILL.md to reference all 22 query templates instead of 21
  2. For bbdata maintainer: Fix the misleading comment in src/templates/reports/registry.ts line 53 (change "12" to "13")

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions