UI: closing the "submit-new-workflow" sidepanel on the workflows list page removes parameters from the URL

[elliotgunton]

Pre-requisites

• I have double-checked my configuration
• I have tested with the :latest image tag (i.e. quay.io/argoproj/workflow-controller:latest) and can confirm the issue still exists on :latest. If not, I have explained why, in detail, in my description below.
• I have searched existing issues and could not find a match for this bug
• I'd like to contribute the fix myself (see contributing guide)

What happened? What did you expect to happen?

While reviewing #15217 I saw that opening and closing the sidepanel removes all the filter parameters from the URL. Unexpected behaviour and is a small quality of life fix. The issue is because of:

argo-workflows/ui/src/workflows/components/workflows-list/workflows-list.tsx

Lines 365 to 368 in 5456d80

	// Remove any lingering query params
	for (const key of queryParams.keys()) {
	qParams[key] = null;
	}

The whole side panel implementation on the workflows list page is a bit weird compared to the workflow template list. It can be tidied up to match.

Version(s)

latest main (5456d80)

Paste a minimal workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflow that uses private images.

* Add some filter parameters (phase)
* Click "submit new workflow"
* Close the side panel
* Observe the URL removing the filter parameters

Logs from the workflow controller

N/A

Logs from in your workflow's wait container

N/A