fix: CLI argument parsing error

Author: das-Abroxas

crates/pithos/src/main.rs

@@ -136,7 +136,7 @@ enum ReadCommands {
         #[arg(value_name = "PATH")]
         path: PathBuf,
         /// Specific byte ranges in the file
-        #[arg(short, long, value_parser=parse_range_input, value_name = "START:END,...")]
+        #[arg(short, long, value_parser=parse_range_input, value_delimiter=',', value_name = "START:END,...")]
         ranges: Option<Vec<Range<u64>>>,
     },
     /// Read the Table of Contents

crates/pithos/src/utils/conversion.rs

@@ -22,27 +22,14 @@ pub fn _to_hex_string(bytes: Vec<u8>) -> String {
     hex_str.join("")
 }
 
-pub fn parse_range_input(input: &str) -> Result<Vec<Range<u64>>, PithosCliError> {
-    if input.is_empty() {
-        return Err(PithosCliError::InvalidArgumentError(
-            "Provided empty ranges argument".to_string(),
-        ));
-    }
-
-    let ranges: Vec<&str> = input.split(',').collect();
-    let mut parsed_ranges = Vec::new();
-    for range in ranges {
-        let parts: Vec<&str> = range.split(':').collect();
-
-        let start = parts[0].trim().parse::<u64>().map_err(|e| {
-            PithosCliError::InvalidArgumentError(format!("Failed to parse range start: {}", e))
-        })?;
-        let end = parts[1].trim().parse::<u64>().map_err(|e| {
-            PithosCliError::InvalidArgumentError(format!("Failed to parse range end: {}", e))
-        })?;
-
-        parsed_ranges.push(start..end)
-    }
+pub fn parse_range_input(input: &str) -> Result<Range<u64>, PithosCliError> {
+    let parts: Vec<&str> = input.split(':').collect();
+    let start = parts[0].trim().parse::<u64>().map_err(|e| {
+        PithosCliError::InvalidArgumentError(format!("Failed to parse range start: {}", e))
+    })?;
+    let end = parts[1].trim().parse::<u64>().map_err(|e| {
+        PithosCliError::InvalidArgumentError(format!("Failed to parse range end: {}", e))
+    })?;
 
-    Ok(parsed_ranges)
+    Ok(start..end)
 }