Fix vcpkg cache paths for Linux and macOS#43
Merged
Conversation
- Fix Linux/macOS cache path from build/Release/vcpkg_installed to build/vcpkg_installed to match VCPKG_INSTALLED_DIR in CMakePresets.json - Add missing vcpkg cache steps to pull-request.yml for all platforms - Bump cache key version to v3 to invalidate stale entries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The vcpkg cache paths in
main.ymlfor Linux and macOS were set tobuild/Release/vcpkg_installed, butCMakePresets.jsonsetsVCPKG_INSTALLED_DIRtobuild/vcpkg_installed(shared across all presets). This path mismatch meant the cache was saving/restoring the wrong directory, causing vcpkg to rebuild all ~60 packages from source on every run (~9 min).Windows was already using the correct path (
build/vcpkg_installed).Additionally,
pull-request.ymlwas missing vcpkg cache steps entirely for all three platforms.Changes
build/Release/vcpkg_installedtobuild/vcpkg_installedinmain.ymlpull-request.ymlfor all three platforms (Linux, Windows, macOS)v3to invalidate stale entriesTiming measurements
"Configure CMake" step (where vcpkg install runs)
Total job time
Workflow runs