Add getOutputMessage() accessor to Statement#45
Merged
Conversation
This was referenced Mar 12, 2026
asfernandes
reviewed
Mar 12, 2026
Owner
|
Please rebase. |
Symmetrical with the existing getInputMessage(), provides direct access to the raw output message buffer for consumers that need to read fetched row data at the raw byte level. Closes asfernandes#42 (REQ-2).
Contributor
Author
|
Rebased onto latest |
asfernandes
reviewed
Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #44
Adds a
getOutputMessage()accessor to theStatementclass, addressing REQ-2 from #42.Problem
StatementexposesgetInputMessage()for raw write access to the input parameter buffer, but there was no correspondinggetOutputMessage()for the output result buffer (outMessagewasprivate).The ODBC driver needs raw access to the output message buffer for:
fetchNext().OdbcConvertdescriptor pointers at offsets within the output message, eliminating a separate buffer and onememcpyper row.Changes
Statement: AddedgetOutputMessage()returningstd::vector<std::byte>&, symmetrical withgetInputMessage().Impact
Sqlda.bufferfor output data and implement N-row prefetch using fb-cpp's buffer as the source.