Skip to content
This repository was archived by the owner on Nov 29, 2018. It is now read-only.

Commit 9b017ad

Browse files
committed
Target .NET Standard 2.0 and add .NET Framework 4.6.1 testing
1 parent 8f970d3 commit 9b017ad

10 files changed

Lines changed: 19 additions & 10 deletions

File tree

build/common.props

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515
<PackageReference Include="Internal.AspNetCore.Sdk" Version="$(InternalAspNetCoreSdkVersion)" PrivateAssets="All" />
1616
</ItemGroup>
1717

18-
<ItemGroup Condition="'$(TargetFrameworkIdentifier)'=='.NETFramework' AND '$(OutputType)'=='library'">
19-
<PackageReference Include="NETStandard.Library" Version="$(BundledNETStandardPackageVersion)" />
18+
<ItemGroup Condition="'$(TargetFrameworkIdentifier)'=='.NETFramework'">
19+
<PackageReference Include="NETStandard.Library.NETFramework" Version="$(NETStandardLibraryNETFrameworkVersion)" />
2020
</ItemGroup>
2121

2222
</Project>

build/dependencies.props

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
<InternalAspNetCoreSdkVersion>2.1.0-*</InternalAspNetCoreSdkVersion>
77
<MoqVersion>4.7.1</MoqVersion>
88
<NETStandardImplicitPackageVersion>$(BundledNETStandardPackageVersion)</NETStandardImplicitPackageVersion>
9+
<NETStandardLibraryNETFrameworkVersion>2.0.0-*</NETStandardLibraryNETFrameworkVersion>
910
<TestSdkVersion>15.3.0-*</TestSdkVersion>
1011
<XunitVersion>2.3.0-beta2-*</XunitVersion>
1112
</PropertyGroup>

samples/LocalizationSample/LocalizationSample.csproj

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,13 @@
33
<Import Project="..\..\build\dependencies.props" />
44

55
<PropertyGroup>
6-
<TargetFramework>netcoreapp2.0</TargetFramework>
6+
<TargetFrameworks>netcoreapp2.0;net461</TargetFrameworks>
77
</PropertyGroup>
88

9+
<ItemGroup Condition="'$(TargetFrameworkIdentifier)'=='.NETFramework'">
10+
<PackageReference Include="NETStandard.Library.NETFramework" Version="$(NETStandardLibraryNETFrameworkVersion)" />
11+
</ItemGroup>
12+
913
<ItemGroup>
1014
<ProjectReference Include="..\..\src\Microsoft.AspNetCore.Localization\Microsoft.AspNetCore.Localization.csproj" />
1115
<ProjectReference Include="..\..\src\Microsoft.Extensions.Localization\Microsoft.Extensions.Localization.csproj" />

src/Microsoft.AspNetCore.Localization.Routing/Microsoft.AspNetCore.Localization.Routing.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
<PropertyGroup>
66
<Product>Microsoft ASP.NET Core</Product>
77
<Description>Provides a request culture provider which gets culture and ui-culture from request's route data.</Description>
8-
<TargetFramework>netcoreapp2.0</TargetFramework>
8+
<TargetFramework>netstandard2.0</TargetFramework>
99
<NoWarn>$(NoWarn);CS1591</NoWarn>
1010
<GenerateDocumentationFile>true</GenerateDocumentationFile>
1111
<PackageTags>aspnetcore;localization</PackageTags>

src/Microsoft.AspNetCore.Localization/Microsoft.AspNetCore.Localization.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
<PropertyGroup>
66
<Product>Microsoft ASP.NET Core</Product>
77
<Description>ASP.NET Core middleware for automatically applying culture information to HTTP requests. Culture information can be specified in the HTTP header, query string, cookie, or custom source.</Description>
8-
<TargetFramework>netcoreapp2.0</TargetFramework>
8+
<TargetFramework>netstandard2.0</TargetFramework>
99
<NoWarn>$(NoWarn);CS1591</NoWarn>
1010
<GenerateDocumentationFile>true</GenerateDocumentationFile>
1111
<PackageTags>aspnetcore;localization</PackageTags>

test/LocalizationWebsite/LocalizationWebsite.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<Import Project="..\..\build\common.props" />
44

55
<PropertyGroup>
6-
<TargetFramework>netcoreapp2.0</TargetFramework>
6+
<TargetFrameworks>netcoreapp2.0;net461</TargetFrameworks>
77
</PropertyGroup>
88

99
<ItemGroup>

test/Microsoft.AspNetCore.Localization.FunctionalTests/Microsoft.AspNetCore.Localization.FunctionalTests.csproj

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@
33
<Import Project="..\..\build\common.props" />
44

55
<PropertyGroup>
6-
<TargetFramework>netcoreapp2.0</TargetFramework>
6+
<TargetFrameworks>netcoreapp2.0;net461</TargetFrameworks>
7+
<TargetFrameworks Condition=" '$(OS)' != 'Windows_NT' ">netcoreapp2.0</TargetFrameworks>
78
</PropertyGroup>
89

910
<ItemGroup>

test/Microsoft.AspNetCore.Localization.Routing.Tests/Microsoft.AspNetCore.Localization.Routing.Tests.csproj

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@
33
<Import Project="..\..\build\common.props" />
44

55
<PropertyGroup>
6-
<TargetFramework>netcoreapp2.0</TargetFramework>
6+
<TargetFrameworks>netcoreapp2.0;net461</TargetFrameworks>
7+
<TargetFrameworks Condition=" '$(OS)' != 'Windows_NT' ">netcoreapp2.0</TargetFrameworks>
78
</PropertyGroup>
89

910
<ItemGroup>

test/Microsoft.AspNetCore.Localization.Tests/Microsoft.AspNetCore.Localization.Tests.csproj

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@
33
<Import Project="..\..\build\common.props" />
44

55
<PropertyGroup>
6-
<TargetFramework>netcoreapp2.0</TargetFramework>
6+
<TargetFrameworks>netcoreapp2.0;net461</TargetFrameworks>
7+
<TargetFrameworks Condition=" '$(OS)' != 'Windows_NT' ">netcoreapp2.0</TargetFrameworks>
78
</PropertyGroup>
89

910
<ItemGroup>

test/Microsoft.Extensions.Localization.Tests/Microsoft.Extensions.Localization.Tests.csproj

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@
33
<Import Project="..\..\build\common.props" />
44

55
<PropertyGroup>
6-
<TargetFramework>netcoreapp2.0</TargetFramework>
6+
<TargetFrameworks>netcoreapp2.0;net461</TargetFrameworks>
7+
<TargetFrameworks Condition=" '$(OS)' != 'Windows_NT' ">netcoreapp2.0</TargetFrameworks>
78
</PropertyGroup>
89

910
<ItemGroup>

0 commit comments

Comments
 (0)