Merge pull request #1394 from assemblee-virtuelle/allow-transient-activities

Allow to post transient activities

Author: srosset81

src/middleware/packages/activitypub/services/activitypub/subservices/activity-handlers/setRightsHandler.js

@@ -1,4 +1,4 @@
-const { hasType } = require('@semapps/ldp');
+const { hasType, getId } = require('@semapps/ldp');
 const { ACTIVITY_TYPES } = require('../../../../constants');
 
 // const removeReadRights = async ({ ctx, recipientUris, resourceUri, skipObjectsWatcher, anon }) => {
@@ -53,7 +53,7 @@ const setRightsHandler = {
   match: '*',
   priority: 1,
   async onEmit(ctx, activity) {
-    const activityUri = activity['@id'] || activity.id;
+    const activityUri = getId(activity);
     const newRecipients = await ctx.call('activitypub.activity.getRecipients', { activity });
     const activityIsPublic = await ctx.call('activitypub.activity.isPublic', { activity });
     /** @type {string} */
@@ -65,14 +65,16 @@ const setRightsHandler = {
       if (!newRecipients.includes(activity.actor)) newRecipients.push(activity.actor);
     }
 
-    // Give read rights to the activity's recipients.
-    await addReadRights({
-      ctx,
-      resourceUri: activityUri,
-      recipientUris: newRecipients,
-      skipObjectsWatcher: true,
-      anon: activityIsPublic
-    });
+    // Give read rights to the recipients, unless the activity is transient
+    if (!activityUri.includes('#')) {
+      await addReadRights({
+        ctx,
+        resourceUri: activityUri,
+        recipientUris: newRecipients,
+        skipObjectsWatcher: true,
+        anon: activityIsPublic
+      });
+    }
 
     // If Create or Update activity, also give rights to the created object.
     if (hasType(activity, ACTIVITY_TYPES.CREATE) || hasType(activity, ACTIVITY_TYPES.UPDATE)) {

src/middleware/packages/activitypub/services/activitypub/subservices/object.js

@@ -1,3 +1,4 @@
+const { getType } = require('@semapps/ldp');
 const { MIME_TYPES } = require('@semapps/mime-types');
 const { OBJECT_TYPES, ACTIVITY_TYPES } = require('../../../constants');
 
@@ -23,26 +24,29 @@ const ObjectService = {
         accept: MIME_TYPES.JSON
       });
     },
-    async process(ctx) {
-      let { activity, actorUri } = ctx.params;
-      let activityType = activity.type || activity['@type'];
-      let objectUri;
+    // If an object is passed directly, wrap it in a Create activity
+    async wrap(ctx) {
+      const { activity } = ctx.params;
 
-      // If an object is passed directly, first wrap it in a Create activity
-      if (Object.values(OBJECT_TYPES).includes(activityType)) {
+      if (Object.values(OBJECT_TYPES).includes(getType(activity))) {
         const { to, cc, '@id': id, ...object } = activity;
-        activityType = ACTIVITY_TYPES.CREATE;
-        activity = {
+        return {
           '@context': object['@context'],
-          type: activityType,
+          type: ACTIVITY_TYPES.CREATE,
           to,
           cc,
           actor: object.attributedTo,
           object
         };
+      } else {
+        return activity;
       }
+    },
+    async process(ctx) {
+      let { activity, actorUri } = ctx.params;
+      let objectUri;
 
-      switch (activityType) {
+      switch (getType(activity)) {
         case ACTIVITY_TYPES.CREATE: {
           // If the object passed is an URI, this is an announcement and there is nothing to process
           if (typeof activity.object === 'string') break;

src/middleware/packages/activitypub/services/activitypub/subservices/outbox.js

@@ -1,6 +1,7 @@
 const fetch = require('node-fetch');
 const { Errors: E } = require('moleculer-web');
 const { MIME_TYPES } = require('@semapps/mime-types');
+const { getType, arrayOf } = require('@semapps/ldp');
 const { collectionPermissionsWithAnonRead, getSlugFromUri, objectIdToCurrent } = require('../../../utils');
 const { ACTOR_TYPES } = require('../../../constants');
 const AwaitActivityMixin = require('../../../mixins/await-activity');
@@ -41,7 +42,8 @@ const OutboxService = {
   },
   actions: {
     async post(ctx) {
-      let { collectionUri, username, ...activity } = ctx.params;
+      let { collectionUri, username, transient, ...activity } = ctx.params;
+      let activityUri;
 
       const collectionExists = await ctx.call('activitypub.collection.exist', { resourceUri: collectionUri });
       if (!collectionExists) {
@@ -69,7 +71,10 @@ const OutboxService = {
         activity['@context'] = await ctx.call('jsonld.context.get');
       }
 
-      if (!ctx.meta.doNotProcessObject) {
+      // Wrap object in Create activity, if necessary
+      activity = await ctx.call('activitypub.object.wrap', { activity });
+
+      if (!ctx.meta.doNotProcessObject && transient !== true) {
         // Process object create, update or delete
         // and return an activity with the object ID
         activity = await ctx.call('activitypub.object.process', { activity, actorUri });
@@ -80,42 +85,44 @@ const OutboxService = {
       }
 
       // Use the current time for the activity's publish date
-      // TODO use it to order the ordered collections
       activity.published = new Date().toISOString();
 
-      const activitiesContainerUri = await ctx.call('activitypub.activity.getContainerUri', {
-        webId: actorUri
-      });
-
-      // There might be a capability attached which should not be persisted
-      // because other's could otherwise read it from the (public) outbox.
-      let { capability, ...activityToPersist } = activity;
+      if (transient === true) {
+        // Object or actor URI + hash with lower case activity
+        activityUri = `${activity.object || activity.actor}#${arrayOf(getType(activity))[0].toLowerCase()}`;
+        activity = { id: activityUri, ...activity };
+      } else {
+        const activitiesContainerUri = await ctx.call('activitypub.activity.getContainerUri', {
+          webId: actorUri
+        });
 
-      const activityUri = await ctx.call('activitypub.activity.post', {
-        containerUri: activitiesContainerUri,
-        resource: activityToPersist,
-        contentType: MIME_TYPES.JSON,
-        webId: 'system' // Post as system since there is no write permission to the activities container
-      });
+        activityUri = await ctx.call('activitypub.activity.post', {
+          containerUri: activitiesContainerUri,
+          resource: activity,
+          contentType: MIME_TYPES.JSON,
+          webId: 'system' // Post as system since there is no write permission to the activities container
+        });
 
-      activityToPersist = await ctx.call('activitypub.activity.get', { resourceUri: activityUri, webId: 'system' });
-      // Reattach capability for further processing (if available).
-      activity = { ...activityToPersist, capability };
+        activity = await ctx.call('activitypub.activity.get', { resourceUri: activityUri, webId: 'system' });
+      }
 
       try {
-        // Notify listeners of activities.
         await ctx.call('activitypub.side-effects.processOutbox', { activity });
       } catch (e) {
-        await ctx.call('activitypub.activity.delete', { resourceUri: activityUri, webId: 'system' });
+        if (transient !== true) {
+          await ctx.call('activitypub.activity.delete', { resourceUri: activityUri, webId: 'system' });
+        }
         // TODO unprocess objects
         throw e;
       }
 
-      // Attach the newly-created activity to the outbox
-      await ctx.call('activitypub.collection.add', {
-        collectionUri,
-        item: activityToPersist
-      });
+      if (transient !== true) {
+        // Attach the newly-created activity to the outbox
+        await ctx.call('activitypub.collection.add', {
+          collectionUri,
+          item: activity
+        });
+      }
 
       const localRecipients = [];
       const remoteRecipients = [];

src/middleware/packages/sync/middlewares/objects-watcher.js

@@ -10,7 +10,7 @@ const handledWacActions = [
 ];
 
 const ObjectsWatcherMiddleware = (config = {}) => {
-  const { baseUrl, podProvider = false, postWithoutRecipients = false } = config;
+  const { baseUrl, podProvider = false, postWithoutRecipients = false, transientActivities = false } = config;
   let relayActor;
   let excludedContainersPathRegex = [];
   let initialized = false;
@@ -75,6 +75,7 @@ const ObjectsWatcherMiddleware = (config = {}) => {
         'activitypub.outbox.post',
         {
           collectionUri: actor.outbox,
+          transient: transientActivities,
           '@context': 'https://www.w3.org/ns/activitystreams',
           ...activity,
           bto: recipients