Fix improper handling of optional file uploads (athena-framework/athena#595)

* Bump `framework` component

Author: Blacksmoke16

CHANGELOG.md

@@ -1,5 +1,14 @@
 # Changelog
 
+## [0.21.1] - 2025-10-04
+
+### Fixed
+
+- Fix improper handling of optional file uploads ([#595]) (George Dietrich) <!-- blacksmoke16 -->
+
+[0.21.1]: https://github.com/athena-framework/framework/releases/tag/v0.21.1
+[#595]: https://github.com/athena-framework/athena/pull/595
+
 ## [0.21.0] - 2025-09-04
 
 ### Changed

shard.yml

@@ -1,6 +1,6 @@
 name: athena
 
-version: 0.21.0
+version: 0.21.1
 
 crystal: ~> 1.14
 

spec/file_parser_spec.cr

@@ -8,6 +8,7 @@ struct FileParserTest < ASPEC::TestCase
     request = new_request(
       body: String.build do |io|
         HTTP::FormData.build io, "boundary" do |form|
+          # Non HTML file input types have a `nil` filename.
           form.field("age", 12)
           form.file(
             "success",
@@ -20,6 +21,18 @@ struct FileParserTest < ASPEC::TestCase
             }
           )
 
+          # Skipped because optional HTML file input types have a `""` filename if no file was selected.
+          form.file(
+            "optional",
+            IO::Memory.new,
+            HTTP::FormData::FileMetadata.new(
+              ""
+            ),
+            headers: HTTP::Headers{
+              "content-type" => "text/plain",
+            }
+          )
+
           form.file(
             "too_big",
             File.open("#{__DIR__}/assets/file-big.txt"),
@@ -75,6 +88,7 @@ struct FileParserTest < ASPEC::TestCase
     file_parser.uploaded_file?(file2.path).should be_false
 
     request.attributes.get("age", String).should eq "12"
+    request.attributes.has?("optional").should be_false
 
     file_parser.clear
 

src/athena.cr

@@ -62,7 +62,7 @@ alias ATHA = ATH::Annotations
 alias ATHR = ATH::Controller::ValueResolvers
 
 module Athena::Framework
-  VERSION = "0.21.0"
+  VERSION = "0.21.1"
 
   # The name of the environment variable used to determine Athena's current environment.
   ENV_NAME = "ATHENA_ENV"

src/file_parser.cr

@@ -21,7 +21,9 @@ class Athena::Framework::FileParser
     uploaded_file_count = 0
 
     HTTP::FormData.parse(request.request) do |part|
-      unless filename = part.filename.presence
+      case filename = part.filename
+      when "" then next
+      when .nil?
         request.attributes.set part.name, part.body.gets_to_end, String
         next
       end