TICKET 0008898: Wrong HTML syntax in the top menu bar (TestLinkOpenSourceTRMS#261)

Aurélien TISNE · atisne · commit 8ad015ae2651 · 2020-06-16T16:47:28.000+02:00
diff --git a/lib/functions/common.php b/lib/functions/common.php
@@ -355,8 +355,8 @@ function initTopMenu(&$db)
         if( $addItem )
         {
           $_SESSION['testprojectTopMenu'] .= "<a href='{$element['url']}' " .
-          "target='{$element['target']}' accesskey='{$element['shortcut']}'" .
-          "tabindex=''" . $idx++ . "''>";
+          "target='{$element['target']}' accesskey='{$element['shortcut']}' " .
+          "tabindex='" . $idx++ . "'>";
 
           if( isset($element['imgKey']) )
           {

Original file line number	Diff line number	Diff line change
`@@ -355,8 +355,8 @@ function initTopMenu(&$db)`
`355`	`355`	`if( $addItem )`
`356`	`356`	`{`
`357`	`357`	`$_SESSION['testprojectTopMenu'] .= "<a href='{$element['url']}' " .`
`358`		`- "target='{$element['target']}' accesskey='{$element['shortcut']}'" .`
`359`		`- "tabindex=''" . $idx++ . "''>";`
	`358`	`+ "target='{$element['target']}' accesskey='{$element['shortcut']}' " .`
	`359`	`+ "tabindex='" . $idx++ . "'>";`
`360`	`360`
`361`	`361`	`if( isset($element['imgKey']) )`
`362`	`362`	`{`