Fix for the double marking via marker tool.

Author: atom7xyz

src/frontend/components/reader/FileReaderContent.tsx

@@ -1,10 +1,11 @@
-import React, { useState, useRef, useEffect, memo, useCallback, useMemo } from 'react';
+import type React from 'react';
+import { useState, useRef, useEffect, memo, useCallback, useMemo } from 'react';
 import { useNavigate } from 'react-router-dom';
 import { useZoom } from '@/lib/contexts/ZoomContext';
 import { useTabs } from '@/lib/contexts/TabsContext';
 import { useEditHistoryContext } from '@/lib/contexts/EditHistoryContext';
 import { getElectronAPI } from '@/lib/navigation';
-import FileReaderTopNavbar, { ZoomValue } from '@/components/reader/FileReaderTopNavbar';
+import FileReaderTopNavbar, { type ZoomValue } from '@/components/reader/FileReaderTopNavbar';
 import NoteBar from '@/components/reader/NoteBar';
 import DocumentViewer, { DEFAULT_FILES, FileType } from '@/components/viewer/DocumentViewer';
 import { ScrollMode } from '@/components/viewer/PDFViewer';
@@ -66,7 +67,7 @@ const FileReaderContent = memo(() => {
   }>({ totalMatches: 0, currentMatch: 0 });
 
   // Store the search function provided by PDFViewer
-  const searchFunctionRef = useRef<(text: string, direction: 'forward' | 'backward') => void | null>(null);
+  const searchFunctionRef = useRef<(text: string, direction: 'forward' | 'backward') => undefined | null>(null);
 
   // Handler for finding text (called from search modal)
   const handleFindText = useCallback((text: string, direction: 'forward' | 'backward') => {
@@ -199,7 +200,7 @@ const FileReaderContent = memo(() => {
   }, [filePath, setIsLoading]);
 
   // Handle page change
-  const handlePageChange = useCallback((newPage: number, manual: boolean = false) => {
+  const handlePageChange = useCallback((newPage: number, manual = false) => {
     if (newPage >= 1 && newPage <= (numPages || 1)) {
       // Update our internal state
       setPageNumber(newPage);

src/frontend/components/reader/FileReaderTopNavbar.tsx

@@ -1,4 +1,4 @@
-import React, { useState, CSSProperties, useEffect, useCallback, useMemo, memo } from 'react';
+import React, { useState, type CSSProperties, useEffect, useCallback, useMemo, memo } from 'react';
 import { useNavigate } from 'react-router-dom';
 import { 
   ArrowLeftIcon,
@@ -31,7 +31,7 @@ import {
   DropdownMenuSeparator,
   DropdownMenuTrigger,
 } from '@/components/ui/dropdown-menu';
-import TabSwitcherModal, { FileTab } from '@/components/modals/TabSwitcherModal';
+import TabSwitcherModal, { type FileTab } from '@/components/modals/TabSwitcherModal';
 import { useTabs } from '@/lib/contexts/TabsContext';
 import { cn } from '@/lib/utils';
 import { ScrollMode } from '@/components/viewer/PDFViewer';
@@ -290,13 +290,15 @@ const DropdownTabItem = memo(({
       }}
     >
       <button
+        type="button"
         className="flex-1 flex items-center text-left" 
         onClick={handleSelect}
       >
         <FileIcon className="h-4 w-4 mr-2 text-muted-foreground" />
         <span className="flex-1 truncate">{tab.name}</span>
       </button>
       <button
+        type="button"
         className="opacity-50 hover:opacity-100"
         onClick={handleClose}
         title="Close"
@@ -594,6 +596,7 @@ const FileReaderTopNavbar = memo(({
 
           {/* Middle section - Edit buttons, Search, View controls, and Zoom */}
           <div className="flex-1 flex items-center justify-center space-x-3" style={dragRegion}>
+            {/* biome-ignore lint/a11y/useKeyWithClickEvents: <explanation> */}
             <div className="relative w-1/4 max-w-xs" onClick={handleSearchClick}>
               <div className="absolute left-3 top-1/2 -translate-y-1/2 text-sidebar-foreground/70">
                 <Search className="h-4 w-4" />

src/frontend/components/reader/FileViewport.tsx

@@ -1,4 +1,5 @@
-import React, { useRef, useState, useEffect, useCallback, useMemo, memo } from 'react';
+import type React from 'react';
+import { useRef, useState, useEffect, useCallback, useMemo, memo } from 'react';
 import { Card } from '../ui/card';
 
 interface FileViewportProps {

src/frontend/components/reader/LeftToolbar.tsx

@@ -1,4 +1,5 @@
-import React, { memo, useState, useRef, useEffect } from 'react';
+import type React from 'react';
+import { memo, useState, useRef, useEffect } from 'react';
 import { Button } from '@/components/ui/button';
 import { 
   Hand, 

src/frontend/components/reader/NoteBar.tsx

@@ -1,4 +1,5 @@
-import React, { useState, useCallback, useMemo, memo, useEffect } from 'react';
+import type React from 'react';
+import { useState, useCallback, useMemo, memo } from 'react';
 import { Button } from '@/components/ui/button';
 import { Label } from '@/components/ui/label';
 import { ScrollArea } from '@/components/ui/scroll-area';
@@ -27,7 +28,7 @@ import {
 import { CSS } from '@dnd-kit/utilities';
 import { restrictToVerticalAxis } from '@dnd-kit/modifiers';
 import { useEditHistoryContext } from '@/lib/contexts/EditHistoryContext';
-import { Note } from '@/lib/types';
+import type { Note } from '@/lib/types';
 
 interface NoteBarProps {
   currentPage: number;
@@ -154,7 +155,7 @@ const SortableNote = memo(({
               className="h-6 w-6" 
               onClick={handleDelete}
             >
-              <span className="sr-only">Delete</span>
+              <span className="sr-only">Delete note</span>
               <svg
                 xmlns="http://www.w3.org/2000/svg"
                 width="24"
@@ -166,9 +167,11 @@ const SortableNote = memo(({
                 strokeLinecap="round"
                 strokeLinejoin="round"
                 className="h-4 w-4 text-muted-foreground"
+                aria-hidden="true"
               >
-                <path d="M18 6L6 18"></path>
-                <path d="M6 6l12 12"></path>
+                <title>Delete icon</title>
+                <path d="M18 6L6 18" />
+                <path d="M6 6l12 12" />
               </svg>
             </Button>
           </div>

src/frontend/components/reader/PageNavigation.tsx

@@ -39,7 +39,7 @@ const PageNavigation = memo(({ pageNumber, numPages, onPageChange, isVisible, is
 
   // Process page input and navigate if valid
   const processPageInput = useCallback(() => {
-    const newPage = parseInt(inputValue) || pageNumber;
+    const newPage = Number.parseInt(inputValue) || pageNumber;
     const maxPage = numPages || 1;
 
     if (newPage >= 1 && newPage <= maxPage && newPage !== pageNumber) {

src/frontend/components/reader/SearchBar.tsx

@@ -1,4 +1,5 @@
-import React, { useState, useRef, useEffect, useCallback } from 'react';
+import type React from 'react';
+import { useState, useRef, useEffect, useCallback } from 'react';
 import { 
   Search, 
   ArrowUp, 
@@ -169,6 +170,7 @@ const SearchBar = ({
             />
             {searchQuery && (
               <button
+                type="button"
                 onClick={handleClearSearch}
                 className="absolute right-2.5 top-1/2 -translate-y-1/2 text-muted-foreground hover:text-foreground"
                 aria-label="Clear search"
@@ -226,9 +228,10 @@ const SearchBar = ({
               Recent Searches
             </div>
             <div className="flex flex-wrap gap-1.5">
-              {recentSearches.map((term, index) => (
+              {recentSearches.map((term) => (
                 <button
-                  key={`${term}-${index}`}
+                  type="button"
+                  key={term}
                   onClick={() => handleRecentSearchClick(term)}
                   className="px-2 py-1 text-xs rounded-md bg-muted hover:bg-muted/80 transition-colors"
                 >

src/frontend/components/viewer/DocumentViewer.tsx

@@ -1,7 +1,8 @@
-import React, { useState, useEffect, useCallback, memo, useRef } from 'react';
+import type React from 'react';
+import { useState, useEffect, useCallback, memo, useRef } from 'react';
 import { Skeleton } from '@/components/ui/skeleton';
 import LoadingModal from '@/components/modals/LoadingModal';
-import { ZoomValue } from '@/components/reader/FileReaderTopNavbar';
+import type { ZoomValue } from '@/components/reader/FileReaderTopNavbar';
 
 // Import the PDFViewer
 import PDFViewer, { ScrollMode } from './PDFViewer';
@@ -213,7 +214,7 @@ const DocumentViewer: React.FC<DocumentViewerProps> = memo(({
             drawingLineWidth={drawingLineWidth}
           />
         );
-      case FileType.UNKNOWN:
+      //case FileType.UNKNOWN:
       default:
         // Only show the fallback PDF for unknown files
         return (
@@ -234,7 +235,7 @@ const DocumentViewer: React.FC<DocumentViewerProps> = memo(({
       {/* Loading Modal - only shown when initially loading a file */}
       <LoadingModal 
         isOpen={showLoadingModal}
-        message={`Loading document...`}
+        message={"Loading document..."}
         fullScreen={false}
       />
     </>