fix(review): address PR feedback

- Enhance deprecation error message with example payload
- Add test case for invalid key type failure mode
- Improve test coverage

Signed-off-by: Scott R. Shinn <scott@atomicorp.com>

Author: atomicturtle

server/oracle-service.py

@@ -102,7 +102,11 @@ def _handle_signing(operation):
         except Exception as e:
             return jsonify({'error': f'Invalid Base64 data: {e}'}), 400
     elif package_hash or repodata_hash:
-        return jsonify({'error': 'Signing by hash is deprecated. Please provide base64 encoded "data".'}), 400
+        err_msg = (
+            'Signing by hash is deprecated. Please provide base64 encoded "data" field instead '
+            '(e.g., {"data": "base64_encoded_content", "key_type": "modern"})'
+        )
+        return jsonify({'error': err_msg}), 400
     else:
         return jsonify({'error': 'Missing "data" field (base64 encoded content required)'}), 400
 

tests/test_signing_fix.py

@@ -70,5 +70,15 @@ def test_sign_binary_data(self):
 
             print("Verification successful!")
 
+    def test_sign_invalid_key_type(self):
+        engine = SigningEngine(gnupg_home=self.gpg_home)
+        data = b"Some data"
+        
+        with self.assertRaises(ValueError) as cm:
+            engine.sign_data(data, 'invalid_key_type')
+        
+        print(f"Caught expected error: {cm.exception}")
+        self.assertIn("Unknown key type", str(cm.exception))
+
 if __name__ == '__main__':
     unittest.main()