Merge pull request #309 from auth0/sdk-3173/fix-get_actions

[SDK-3173] Default to 'None' for `deployed` on GET /api/v2/actions/actions endpoint

Author: adamjmcgrath

auth0/v3/management/actions.py

@@ -35,7 +35,7 @@ def _url(self, *args):
                 url = '{}/{}'.format(url, p)
         return url
 
-    def get_actions(self, trigger_id=None, action_name=None, deployed=False, installed=False, page=None, per_page=None):
+    def get_actions(self, trigger_id=None, action_name=None, deployed=None, installed=False, page=None, per_page=None):
         """Get all actions.
 
         Args:
@@ -58,10 +58,14 @@ def get_actions(self, trigger_id=None, action_name=None, deployed=False, install
 
         See: https://auth0.com/docs/api/management/v2#!/Actions/get_actions
         """
+
+        if deployed is not None:
+            deployed = str(deployed).lower()
+
         params = {
             'triggerId': trigger_id,
             'actionName': action_name,
-            'deployed': str(deployed).lower(),
+            'deployed': deployed,
             'installed': str(installed).lower(),
             'page': page,
             'per_page': per_page
@@ -111,17 +115,17 @@ def delete_action(self, id, force=False):
         Args:
            id (str): ID of the action to delete.
 
-           force (bool, optional): True to force action deletion detaching bindings, 
+           force (bool, optional): True to force action deletion detaching bindings,
                False otherwise. Defaults to False.
-        
+
         See: https://auth0.com/docs/api/management/v2#!/Actions/delete_action
         """
         params = {
             'force': str(force).lower()
         }
 
         return self.client.delete(self._url('actions', id), params=params)
-        
+
     def get_triggers(self):
         """Retrieve the set of triggers currently available within actions.
 
@@ -132,7 +136,7 @@ def get_triggers(self):
         return self.client.get(self._url('triggers'), params=params)
 
     def get_execution(self, id):
-        """Get information about a specific execution of a trigger. 
+        """Get information about a specific execution of a trigger.
 
         Args:
            id (str): The ID of the execution to retrieve.
@@ -145,7 +149,7 @@ def get_execution(self, id):
 
     def get_action_versions(self, id, page=None, per_page=None):
         """Get all of an action's versions.
-        
+
         Args:
            id (str): The ID of the action.
 
@@ -185,7 +189,7 @@ def get_trigger_bindings(self, id, page=None, per_page=None):
         return self.client.get(self._url('triggers', id, 'bindings'), params=params)
 
     def get_action_version(self, action_id, version_id):
-        """Retrieve a specific version of an action. 
+        """Retrieve a specific version of an action.
 
         Args:
            action_id (str): The ID of the action.
@@ -227,8 +231,8 @@ def update_trigger_bindings(self, id, body):
         Args:
            id (str): The ID of the trigger to update.
 
-           body (dict): Attributes for the updated trigger binding. 
-        
+           body (dict): Attributes for the updated trigger binding.
+
         See: https://auth0.com/docs/api/management/v2#!/Actions/patch_bindings
         """
-        return self.client.patch(self._url('triggers', id, 'bindings'), data=body)
+        return self.client.patch(self._url('triggers', id, 'bindings'), data=body)

auth0/v3/test/management/test_actions.py

@@ -16,20 +16,19 @@ def test_get_actions(self, mock_rc):
         mock_instance = mock_rc.return_value
 
         c = Actions(domain='domain', token='jwttoken')
-        c.get_actions()
 
+        c.get_actions()
         args, kwargs = mock_instance.get.call_args
 
         self.assertEqual('https://domain/api/v2/actions/actions', args[0])
         self.assertEqual(kwargs['params'], {'triggerId': None,
                                             'actionName': None,
-                                            'deployed': 'false',
+                                            'deployed': None,
                                             'installed': 'false',
                                             'page': None,
                                             'per_page': None})
 
         c.get_actions('trigger-id', 'action-name', True, True,  0, 5)
-
         args, kwargs = mock_instance.get.call_args
 
         self.assertEqual('https://domain/api/v2/actions/actions', args[0])
@@ -40,6 +39,17 @@ def test_get_actions(self, mock_rc):
                                             'page': 0,
                                             'per_page': 5})
 
+        c.get_actions('trigger-id', 'action-name', False, True,  0, 5)
+        args, kwargs = mock_instance.get.call_args
+
+        self.assertEqual('https://domain/api/v2/actions/actions', args[0])
+        self.assertEqual(kwargs['params'], {'triggerId': 'trigger-id',
+                                            'actionName': 'action-name',
+                                            'deployed': 'false',
+                                            'installed': 'true',
+                                            'page': 0,
+                                            'per_page': 5})
+
     @mock.patch('auth0.v3.management.actions.RestClient')
     def test_create_action(self, mock_rc):
         mock_instance = mock_rc.return_value
@@ -195,7 +205,7 @@ def test_rollback_action(self, mock_rc):
         args, kwargs = mock_instance.post.call_args
 
         self.assertEqual('https://domain/api/v2/actions/actions/action-id/versions/version-id/deploy', args[0])
-        self.assertEqual(kwargs['data'], {})   
+        self.assertEqual(kwargs['data'], {})
 
     @mock.patch('auth0.v3.management.actions.RestClient')
     def test_update_trigger_bindings(self, mock_rc):
@@ -207,4 +217,4 @@ def test_update_trigger_bindings(self, mock_rc):
         args, kwargs = mock_instance.patch.call_args
 
         self.assertEqual('https://domain/api/v2/actions/triggers/trigger-id/bindings', args[0])
-        self.assertEqual(kwargs['data'], {'a': 'b', 'c': 'd'})  
+        self.assertEqual(kwargs['data'], {'a': 'b', 'c': 'd'})