Skip to content

Commit d12b0c6

Browse files
authored
Merge pull request #99 from josephschorr/remove-hard-limits
Remove hard-coded limits to make them configurable in SpiceDB
2 parents 895d1dd + 41697b7 commit d12b0c6

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

authzed/api/v1/experimental_service.proto

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ message BulkExportRelationshipsRequest {
116116
// relationships the server can return in one page. By default, the server
117117
// will pick a page size, and the server is free to choose a smaller size
118118
// at will.
119-
uint32 optional_limit = 2 [(validate.rules).uint32 = {gte:0, lte: 10000}];
119+
uint32 optional_limit = 2 [(validate.rules).uint32 = {gte:0}];
120120

121121
// optional_cursor, if specified, indicates the cursor after which results
122122
// should resume being returned. The cursor can be found on the

authzed/api/v1/permission_service.proto

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ message ReadRelationshipsRequest {
212212
// before the stream is closed on the server side. By default, the stream will continue
213213
// resolving relationships until exhausted or the stream is closed due to the client or a
214214
// network issue.
215-
uint32 optional_limit = 3 [(validate.rules).uint32 = {gte:0, lte: 1000}];
215+
uint32 optional_limit = 3 [(validate.rules).uint32 = {gte:0}];
216216

217217
// optional_cursor, if specified, indicates the cursor after which results should resume being returned.
218218
// The cursor can be found on the ReadRelationshipsResponse object.
@@ -286,7 +286,7 @@ message DeleteRelationshipsRequest {
286286
// the deletion call will fail with an error to prevent partial deletion. If partial deletion
287287
// is needed, specify below that partial deletion is allowed. Partial deletions can be used
288288
// in a loop to delete large amounts of relationships in a *non-transactional* manner.
289-
uint32 optional_limit = 3 [(validate.rules).uint32 = {gte:0, lte: 1000}];
289+
uint32 optional_limit = 3 [(validate.rules).uint32 = {gte:0}];
290290

291291
// optional_allow_partial_deletions, if true and a limit is specified, will delete matching found
292292
// relationships up to the count specified in optional_limit, and no more.
@@ -473,7 +473,7 @@ message LookupResourcesRequest {
473473
// before the stream is closed on the server side. By default, the stream will continue
474474
// resolving resources until exhausted or the stream is closed due to the client or a
475475
// network issue.
476-
uint32 optional_limit = 6 [(validate.rules).uint32 = {gte:0, lte: 1000}];
476+
uint32 optional_limit = 6 [(validate.rules).uint32 = {gte:0}];
477477

478478
// optional_cursor, if specified, indicates the cursor after which results should resume being returned.
479479
// The cursor can be found on the LookupResourcesResponse object.
@@ -566,7 +566,7 @@ message LookupSubjectsRequest {
566566
// for each invocation of the API.
567567
//
568568
// ***IT IS UP TO THE CALLER IN THIS CASE TO COMBINE THE EXCLUSIONS IF DESIRED***
569-
uint32 optional_concrete_limit = 7 [(validate.rules).uint32 = {gte:0, lte: 1000}];
569+
uint32 optional_concrete_limit = 7 [(validate.rules).uint32 = {gte:0}];
570570

571571
// optional_cursor, if specified, indicates the cursor after which results should resume being returned.
572572
// The cursor can be found on the LookupSubjectsResponse object.

0 commit comments

Comments
 (0)