fix: Resolve multiple customer-blocking bugs (#126, #131, #132)

Fix class-transformer version mismatch (0.3.1 -> 0.5.1) causing silent
deserialization failures in generated projects. Remove @ts-ignore from
Integer interface so consumers with skipLibCheck:false can compile.
Fix timezone-dependent test failure in log-delivery tests. Add PyPI
CD workflow for automated plugin releases.

Closes #126, #131, #132

Author: PeterNigh

.github/workflows/pypi-release.yaml

@@ -0,0 +1,25 @@
+# This workflow will release project to PyPI
+name: CloudFormation CLI TypeScript Plugin Release
+on:
+  release:
+    types: [published]
+jobs:
+  build:
+    if: endsWith(github.ref, '-plugin')
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - name: Set up Python 3.11
+        uses: actions/setup-python@v5
+        with:
+          python-version: 3.11
+      - name: Install dependencies
+        run: |
+          pip install --upgrade wheel twine
+      - name: Package project
+        run: |
+          python setup.py sdist bdist_wheel
+      - name: Publish distribution to PyPI
+        uses: pypa/gh-action-pypi-publish@release/v1
+        with:
+          password: ${{ secrets.PYPI_API_KEY_CLOUDFORMATION_CLI_TYPESCRIPT_PLUGIN }}

python/rpdk/typescript/templates/package.json

@@ -14,7 +14,7 @@
     },
     "dependencies": {
         "{{lib_name}}": "{{lib_path}}",
-        "class-transformer": "0.3.1"
+        "class-transformer": "0.5.1"
     },
     "devDependencies": {
         "@types/node": "^20.0.0",

src/interface.ts

@@ -66,9 +66,7 @@ export interface Callable<R extends Array<any>, T> {
     (...args: R): T;
 }
 
-// @ts-ignore
-// eslint-disable-next-line
-interface Integer extends BigInt {
+interface Integer {
     /**
      * Defines the default JSON representation of
      * Integer (BigInt) to be a number.
@@ -78,11 +76,12 @@ interface Integer extends BigInt {
     /** Returns the primitive value of the specified object. */
     valueOf(): integer;
 
+    toString(radix?: number): string;
+
     readonly [Symbol.toStringTag]: 'Integer';
 }
 
-// @ts-ignore
-interface IntegerConstructor extends BigIntConstructor {
+interface IntegerConstructor {
     (value?: bigint | integer | boolean | number | string): bigint;
     readonly prototype: Integer;
     /**
@@ -96,13 +95,11 @@ interface IntegerConstructor extends BigIntConstructor {
 /**
  * Wrapper with additional JSON serialization for bigint type
  */
-// @ts-ignore
-export const Integer: IntegerConstructor = new Proxy(BigInt, {
-    // @ts-ignore
+export const Integer: IntegerConstructor = new Proxy(BigInt as unknown as IntegerConstructor, {
     apply(
         target: IntegerConstructor,
         _thisArg: unknown,
-        argArray?: unknown[]
+        argArray: unknown[]
     ): integer {
         target.prototype.toJSON = function (): number {
             return Number(this.valueOf());
@@ -118,8 +115,7 @@ export const Integer: IntegerConstructor = new Proxy(BigInt, {
             return true;
         };
         target.isSafeInteger = isSafeInteger;
-        // @ts-expect-error argArray is unknown
-        const value = target(...argArray);
+        const value = target(...(argArray as [bigint | integer | boolean | number | string]));
         if (value && !isSafeInteger(value)) {
             throw new RangeError(`Value is not a safe integer: ${value.toString()}`);
         }

tests/lib/log-delivery.test.ts

@@ -1271,11 +1271,11 @@ describe('when delivering logs', () => {
             loggerProxy.addLogPublisher(s3Logger);
 
             loggerProxy.log('count: [%d]', 5.12);
-            loggerProxy.log('timestamp: [%s]', new Date('2020-01-01'));
+            loggerProxy.log('timestamp: [%s]', new Date('2020-01-01').toISOString());
 
-            loggerProxy.log('timestamp: [%s]', new Date('2020-01-02'));
-            loggerProxy.log('timestamp: [%s]', new Date('2020-01-03'));
-            loggerProxy.log('timestamp: [%s]', new Date('2020-01-04'));
+            loggerProxy.log('timestamp: [%s]', new Date('2020-01-02').toISOString());
+            loggerProxy.log('timestamp: [%s]', new Date('2020-01-03').toISOString());
+            loggerProxy.log('timestamp: [%s]', new Date('2020-01-04').toISOString());
             expect(inspect.defaultOptions.depth).toBe(8);
             await loggerProxy.waitCompletion();