I've noticed that shellcheck picks up numerous real issues with the scripts in this repo. For example this is a commit fixing only the issue of local not propagating the return value from assignment (which means the $? checks after it will never fail) viraptor@9d55660
There are a few others as well.
It looks like the scripts could use a cleanup beyond a single PR.
I've noticed that shellcheck picks up numerous real issues with the scripts in this repo. For example this is a commit fixing only the issue of
localnot propagating the return value from assignment (which means the$?checks after it will never fail) viraptor@9d55660There are a few others as well.
It looks like the scripts could use a cleanup beyond a single PR.