fix: ensure the same error listener is not attached multiple times (#599)

Author: karenc-bq

mysql/lib/mysql_error_handler.ts

@@ -24,6 +24,8 @@ export class MySQLErrorHandler implements ErrorHandler {
   private unexpectedError: Error | null = null;
   protected static readonly SYNTAX_ERROR_CODES = ["42000", "42S02"];
   protected static readonly SYNTAX_ERROR_MESSAGE = "You have an error in your SQL syntax";
+  protected isNoOpListenerAttached = false;
+  protected isTrackingListenerAttached = false;
 
   protected noOpListener(error: any) {
     // Ignore the received error.
@@ -80,27 +82,32 @@ export class MySQLErrorHandler implements ErrorHandler {
   }
 
   attachErrorListener(clientWrapper: ClientWrapper | undefined): void {
-    if (!clientWrapper || !clientWrapper.client) {
+    if (!clientWrapper || !clientWrapper.client || this.isTrackingListenerAttached) {
       return;
     }
     this.unexpectedError = null;
-    clientWrapper.client.removeListener("error", this.noOpListener);
-    clientWrapper.client.on("error", this.trackingListener);
+    clientWrapper.client.connection.removeListener("error", this.noOpListener);
+    this.isNoOpListenerAttached = false;
+    clientWrapper.client.connection.on("error", this.trackingListener);
+    this.isTrackingListenerAttached = true;
   }
 
   attachNoOpErrorListener(clientWrapper: ClientWrapper | undefined): void {
-    if (!clientWrapper || !clientWrapper.client) {
+    if (!clientWrapper || !clientWrapper.client || this.isNoOpListenerAttached) {
       return;
     }
-    clientWrapper.client.removeListener("error", this.trackingListener);
-    clientWrapper.client.on("error", this.noOpListener);
+    clientWrapper.client.connection.removeListener("error", this.trackingListener);
+    this.isTrackingListenerAttached = false;
+    clientWrapper.client.connection.on("error", this.noOpListener);
+    this.isNoOpListenerAttached = true;
   }
 
   removeErrorListener(clientWrapper: ClientWrapper | undefined): void {
     if (!clientWrapper || !clientWrapper.client) {
       return;
     }
 
-    clientWrapper.client.removeListener("error", this.trackingListener);
+    clientWrapper.client.connection.removeListener("error", this.trackingListener);
+    this.isTrackingListenerAttached = false;
   }
 }

pg/lib/abstract_pg_error_handler.ts

@@ -24,6 +24,8 @@ export abstract class AbstractPgErrorHandler implements ErrorHandler {
   protected unexpectedError: Error | null = null;
   protected static readonly SYNTAX_ERROR_CODE = "42601";
   protected static readonly SYNTAX_ERROR_MESSAGE = "syntax error";
+  protected isNoOpListenerAttached = false;
+  protected isTrackingListenerAttached = false;
 
   abstract getNetworkErrors(): string[];
 
@@ -84,20 +86,24 @@ export abstract class AbstractPgErrorHandler implements ErrorHandler {
   }
 
   attachErrorListener(clientWrapper: ClientWrapper | undefined): void {
-    if (!clientWrapper || !clientWrapper.client) {
+    if (!clientWrapper || !clientWrapper.client || this.isTrackingListenerAttached) {
       return;
     }
     this.unexpectedError = null;
     clientWrapper.client.removeListener("error", this.noOpListener);
+    this.isNoOpListenerAttached = false;
     clientWrapper.client.on("error", this.trackingListener);
+    this.isTrackingListenerAttached = true;
   }
 
   attachNoOpErrorListener(clientWrapper: ClientWrapper | undefined): void {
-    if (!clientWrapper || !clientWrapper.client) {
+    if (!clientWrapper || !clientWrapper.client || this.isNoOpListenerAttached) {
       return;
     }
     clientWrapper.client.removeListener("error", this.trackingListener);
+    this.isTrackingListenerAttached = false;
     clientWrapper.client.on("error", this.noOpListener);
+    this.isNoOpListenerAttached = true;
   }
 
   removeErrorListener(clientWrapper: ClientWrapper | undefined): void {
@@ -106,5 +112,6 @@ export abstract class AbstractPgErrorHandler implements ErrorHandler {
     }
 
     clientWrapper.client.removeListener("error", this.trackingListener);
+    this.isTrackingListenerAttached = false;
   }
 }