Skip to content

Commit 69e8801

Browse files
committed
error logs
1 parent a6c06f4 commit 69e8801

2 files changed

Lines changed: 13 additions & 5 deletions

File tree

src/aws-cpp-sdk-core/include/smithy/client/SmithyEventStreamingAsyncTask.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
#include <aws/core/utils/event/EventEncoderStream.h>
1313
#include <aws/core/utils/event/EventStreamHandler.h>
1414
#include <aws/core/utils/logging/ErrorMacros.h>
15-
#include <smithy/client/AwsSmithyClientAsyncRequestContext.h>
1615

1716

1817
namespace Aws {

tools/scripts/codegen/format_util.py

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,12 +39,21 @@ def format_directories(directory_list):
3939
for filepaths_file in filepaths_files:
4040
cmd = ['pipx', 'run', f'clang-format=={CLANG_FORMAT_VERSION}',
4141
f'--files={filepaths_file.name}', '-i', '-style=file:.clang-format']
42-
p = subprocess.Popen(cmd)
43-
processes.append(p)
42+
p = subprocess.Popen(cmd, stderr=subprocess.PIPE)
43+
processes.append((p, cmd))
4444
print(f"Formatting generated files: {list2cmdline(cmd)}")
4545

46-
for p in processes:
47-
p.wait()
46+
failed = False
47+
for p, cmd in processes:
48+
_, stderr = p.communicate()
49+
if p.returncode != 0:
50+
print(f"ERROR: clang-format failed with exit code {p.returncode}: {list2cmdline(cmd)}")
51+
if stderr:
52+
print(f" stderr: {stderr.decode().strip()}")
53+
failed = True
54+
55+
if failed:
56+
raise RuntimeError("One or more clang-format processes failed")
4857

4958
# Clean up temp file
5059
for filepaths_file in filepaths_files:

0 commit comments

Comments
 (0)