fix linting warnings

Author: ayoub-assis

.github/workflows/linting.yml

@@ -23,7 +23,5 @@ jobs:
         run: echo "$HOME/.local/bin" >> $GITHUB_PATH
       - name: Install venv
         run: poetry install
-      - name: Run Flake8
-        run: poetry run flake8
       - name: Run Pylint
         run: shopt -s globstar && poetry run pylint ./**/*.py

.github/workflows/pypi-publish.yml

@@ -2,7 +2,7 @@ name: Publish to PyPI
 on:
   push:
     tags:
-      - v*.*.*
+      - v*
 
 jobs:
   publish:
@@ -17,7 +17,7 @@ jobs:
         with:
           python-version: ${{ steps.package.outputs.content }}
       - name: Install Poetry
-        run: curl -sSL https://raw.githubusercontent.com/python-poetry/poetry/master/get-poetry.py | python
+        run: curl -sSL https://install.python-poetry.org | python3 -
       - name: Add Poetry to path
         run: echo "${HOME}/.poetry/bin" >> $GITHUB_PATH
       - name: Install venv

.python-version

@@ -1 +1 @@
-3.7.13
+3.8.13

lgg/__init__.py

@@ -1,3 +1,6 @@
+""" Z
+
+"""
 from ._logger import get_logger
 
 logger = get_logger()

lgg/_logger.py

@@ -1,3 +1,6 @@
+""" A
+
+"""
 from logging import DEBUG, Formatter, StreamHandler, getLogger
 
 __all__ = ['get_logger']
@@ -18,12 +21,17 @@
 
 
 class MyHandler(StreamHandler):
+    """ B
+
+    """
 
     def __init__(self, ):
         super().__init__()
 
 
 def get_logger(name=DEFAULT_NAME):
+    """ C
+    """
     logger = getLogger(name)
 
     cond = True
@@ -40,10 +48,10 @@ def get_logger(name=DEFAULT_NAME):
         else:
             fmr = _ColoredFormatter('%(asctime)s - %(name)s '
                                     '- %(levelname)s:  %(message)s')
-        ch = MyHandler()
-        ch.setLevel(DEBUG)
-        ch.setFormatter(fmr)
-        logger.addHandler(ch)
+        handler = MyHandler()
+        handler.setLevel(DEBUG)
+        handler.setFormatter(fmr)
+        logger.addHandler(handler)
 
     return logger
 

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "lgg"
-version = "0.2.1"
+version = "0.2.3"
 description = "A simple yet fancy logger for Python scripts"
 authors = ["Ayoub Assis <assis.ayoub@gmail.com>"]
 license = "MIT License"
@@ -17,11 +17,10 @@ keywords = [
 ]
 
 [tool.poetry.dependencies]
-python = "^3.7"
+python = "^3.8"
 
 [tool.poetry.dev-dependencies]
 pytest = "^7.1.2"
-flake9 = "^3.8.3"
 pylint = "^2.13.9"
 
 [build-system]

tests/test_import.py

@@ -1,12 +1,19 @@
+""" C
+"""
+
+from lgg import get_logger
+from lgg import logger
 
 
 def test_import():
-    from lgg import get_logger
+    """ C
+    """
     get_logger()
 
 
 def test_logging():
-    from lgg import logger
+    """ C
+    """
 
     logger.info('This is an info message')
     logger.debug('Debugging message')

tests/test_logger_names.py

@@ -1,23 +1,33 @@
+""" C
+"""
+
+from lgg import get_logger
+from lgg import logger
+
+
 def test_anonymous():
-    from lgg import logger
+    """ C
+    """
     assert logger.name == 'nameless'
 
 
 def test_different_names():
-    from lgg import get_logger
+    """ C
+    """
     print()
-    l = list(range(1, 4))
-    loggers = [get_logger(f'logger{i}') for i in l]
+    list_range = list(range(1, 4))
+    loggers = [get_logger(f'logger{i}') for i in list_range]
 
-    for i, logger in zip(l, loggers):
-        assert logger.name == f'logger{i}'
-        logger.info(f'Hello from logger {i}')
+    for i, _logger in zip(list_range, loggers):
+        assert _logger.name == f'logger{i}'
+        _logger.info(f'Hello from logger {i}')
 
 
 def test_same_names():
-    from lgg import get_logger
+    """ C
+    """
     loggers = [get_logger('logger_name') for _ in range(2)]
 
-    for logger in loggers:
-        logger.info('Hello!')
-        logger.error('Bye!')
+    for _logger in loggers:
+        _logger.info('Hello!')
+        _logger.error('Bye!')