Merge pull request #127 from g-gabber/master

Allows usage of Emoji's in string values

0e307e7 added allowSurrogateChars as default option for xmlBuilder
7d44897 added emoji tests
4deb82a replace the unicode string construction in the test files

Author: eg-ops

lib/serializer.js

@@ -15,7 +15,7 @@ var xmlBuilder    = require('xmlbuilder')
 exports.serializeMethodCall = function(method, params, encoding) {
   var params = params || []
 
-  var options = { version: '1.0' }
+  var options = { version: '1.0', allowSurrogateChars: true }
 
   if (encoding) {
     options.encoding = encoding
@@ -45,7 +45,7 @@ exports.serializeMethodCall = function(method, params, encoding) {
  *   - {String} xml           - The method response XML.
  */
 exports.serializeMethodResponse = function(result) {
-  var xml = xmlBuilder.create('methodResponse', { version: '1.0' })
+  var xml = xmlBuilder.create('methodResponse', { version: '1.0', allowSurrogateChars: true })
     .ele('params')
       .ele('param')
 
@@ -56,7 +56,7 @@ exports.serializeMethodResponse = function(result) {
 }
 
 exports.serializeFault = function(fault) {
-  var xml = xmlBuilder.create('methodResponse', { version: '1.0' })
+  var xml = xmlBuilder.create('methodResponse', { version: '1.0', allowSurrogateChars: true })
     .ele('fault')
 
   serializeValue(fault, xml)

test/fixtures/good_food/string_emoji.xml

@@ -0,0 +1 @@
+<?xml version="1.0"?><methodCall><methodName>testMethod</methodName><params><param><value><string>😁</string></value></param></params></methodCall>

test/fixtures/good_food/string_emoji_response.xml

@@ -0,0 +1 @@
+<?xml version="1.0"?><methodResponse><params><param><value><string>😁</string></value></param></params></methodResponse>

test/serializer_test.js

@@ -129,6 +129,13 @@ vows.describe('Serializer').addBatch({
           }
         , 'contains the empty string': assertXml('good_food/string_empty_call.xml')
         }
+      , 'with a string contains emoji': {
+          topic: function () {
+              var value = new Buffer('f09f9881', 'hex').toString('utf-8')
+              return Serializer.serializeMethodCall('testMethod', [value])
+          }
+        , 'contains a smiley' : assertXml('good_food/string_emoji.xml')
+        }
       }
 
     , 'undefined' : {
@@ -319,6 +326,13 @@ vows.describe('Serializer').addBatch({
           }
         , 'contains the empty string': assertXml('good_food/string_empty_response.xml')
         }
+      , 'with string contains emoji' : {
+          topic: function () {
+            var value = new Buffer('f09f9881', 'hex').toString('utf-8')
+            return Serializer.serializeMethodResponse(value)
+          }
+        , 'contains emoji': assertXml('good_food/string_emoji_response.xml')
+        }
       }
 
     , 'undefined' : {