Cache-bust extension favicons and bump icon asset version

Author: baboonzero

assets/icons/icon-v2-128.png

@@ -2,12 +2,12 @@
   "manifest_version": 3,
   "name": "Chrome Activity Reader",
   "description": "Track tab-level activity across Chrome windows and review what you worked on recently.",
-  "version": "0.1.0",
+  "version": "0.1.1",
   "icons": {
-    "16": "assets/icons/icon-16.png",
-    "32": "assets/icons/icon-32.png",
-    "48": "assets/icons/icon-48.png",
-    "128": "assets/icons/icon-128.png"
+    "16": "assets/icons/icon-v2-16.png",
+    "32": "assets/icons/icon-v2-32.png",
+    "48": "assets/icons/icon-v2-48.png",
+    "128": "assets/icons/icon-v2-128.png"
   },
   "permissions": [
     "tabs",

assets/icons/icon-v2-16.png

@@ -186,6 +186,12 @@ Chronological execution log:
       - settings/dashboard round-trip in same tab
       - unchanged tab count across round-trip sequence
 
+33. Fixed favicon cache regression in extension tabs:
+    - introduced cache-busted icon asset set (`icon-v2-*`)
+    - updated manifest icons and bumped extension version to `0.1.1`
+    - updated dashboard/panel/settings favicon links and header icon references
+    - extended smoke assertions to require `icon-v2-32.png` favicon path in both dashboard and settings
+
 ## 4. What Were The Decisions That We Took?
 
 ### Product/Architecture Decisions
@@ -331,6 +337,10 @@ Primary commits:
 - `assets/icons/icon-32.png`
 - `assets/icons/icon-48.png`
 - `assets/icons/icon-128.png`
+- `assets/icons/icon-v2-16.png`
+- `assets/icons/icon-v2-32.png`
+- `assets/icons/icon-v2-48.png`
+- `assets/icons/icon-v2-128.png`
 - `assets/fonts/space-grotesk-400.ttf`
 - `assets/fonts/space-grotesk-500.ttf`
 - `assets/fonts/space-grotesk-700.ttf`

assets/icons/icon-v2-32.png

@@ -29,6 +29,7 @@ async function run() {
 
     const dashboardPage = await context.newPage();
     await dashboardPage.goto(dashboardUrl, { waitUntil: "domcontentloaded" });
+    const dashboardFaviconHref = await dashboardPage.getAttribute('link[rel="icon"]', "href");
 
     const heading = await dashboardPage.textContent("h1");
     const activityListCount = await dashboardPage.locator("#activity-list").count();
@@ -59,6 +60,7 @@ async function run() {
     await dashboardPage.waitForURL((url) => url.toString().endsWith("/ui/settings.html"), { timeout: 5_000 });
     const settingsHeading = await dashboardPage.textContent("h1");
     const settingsOpenedInCurrentTab = dashboardPage.url().endsWith("/ui/settings.html");
+    const settingsFaviconHref = await dashboardPage.getAttribute('link[rel="icon"]', "href");
     const pageCountAfterOpenSettings = context.pages().length;
 
     await dashboardPage.click("#open-side-panel");
@@ -74,6 +76,13 @@ async function run() {
 
     await dashboardPage.click("#open-settings");
     await dashboardPage.waitForURL((url) => url.toString().endsWith("/ui/settings.html"), { timeout: 5_000 });
+    await dashboardPage.waitForFunction(
+      () =>
+        document.body?.dataset?.theme === "light" &&
+        document.querySelector("#theme")?.value === "light",
+      null,
+      { timeout: 5_000 }
+    );
     const settingsTheme = await dashboardPage.getAttribute("body", "data-theme");
     const settingsThemeValue = await dashboardPage.inputValue("#theme");
     const themeSelectContrast = await dashboardPage.evaluate(() => {
@@ -126,6 +135,8 @@ async function run() {
       openPanelOnActionClick: status?.openPanelOnActionClick,
       runtimeAfterDashboardSidePanel,
       runtimeAfterSettingsSidePanel,
+      dashboardFaviconHref,
+      settingsFaviconHref,
       settingsHeading,
       settingsOpenedInCurrentTab,
       pageCountAfterOpenSettings,
@@ -151,6 +162,8 @@ async function run() {
       result.runtimeStatusOk !== true ||
       result.sidePanelApiAvailable !== true ||
       result.openPanelOnActionClick !== true ||
+      !String(result.dashboardFaviconHref || "").includes("icon-v2-32.png") ||
+      !String(result.settingsFaviconHref || "").includes("icon-v2-32.png") ||
       result.runtimeAfterDashboardSidePanel?.lastOpenSidePanelResult?.ok !== true ||
       !["sender_window", "all_windows"].includes(result.runtimeAfterDashboardSidePanel?.lastOpenSidePanelResult?.mode) ||
       result.runtimeAfterSettingsSidePanel?.lastOpenSidePanelResult?.ok !== true ||

assets/icons/icon-v2-48.png

@@ -4,15 +4,15 @@
     <meta charset="utf-8" />
     <meta name="viewport" content="width=device-width, initial-scale=1" />
     <title>Chrome Activity Reader</title>
-    <link rel="icon" href="../assets/icons/icon-32.png" />
+    <link rel="icon" href="../assets/icons/icon-v2-32.png" />
     <link rel="stylesheet" href="./activity.css" />
   </head>
   <body data-surface="full" data-theme="dark">
     <main class="shell">
       <header class="hero">
         <div class="brand">
           <div class="brand-mark" aria-hidden="true">
-            <img src="../assets/icons/icon-48.png" alt="" />
+            <img src="../assets/icons/icon-v2-48.png" alt="" />
           </div>
           <div>
             <h1>Chrome Activity Reader</h1>

manifest.json

@@ -4,15 +4,15 @@
     <meta charset="utf-8" />
     <meta name="viewport" content="width=device-width, initial-scale=1" />
     <title>Activity Panel</title>
-    <link rel="icon" href="../assets/icons/icon-32.png" />
+    <link rel="icon" href="../assets/icons/icon-v2-32.png" />
     <link rel="stylesheet" href="./activity.css" />
   </head>
   <body data-surface="panel" data-theme="dark">
     <main class="shell">
       <header class="hero">
         <div class="brand">
           <div class="brand-mark" aria-hidden="true">
-            <img src="../assets/icons/icon-48.png" alt="" />
+            <img src="../assets/icons/icon-v2-48.png" alt="" />
           </div>
           <div>
             <h1>Activity Reader</h1>

project-history.md

@@ -4,7 +4,7 @@
     <meta charset="utf-8" />
     <meta name="viewport" content="width=device-width, initial-scale=1" />
     <title>Activity Reader Settings</title>
-    <link rel="icon" href="../assets/icons/icon-32.png" />
+    <link rel="icon" href="../assets/icons/icon-v2-32.png" />
     <link rel="stylesheet" href="./activity.css" />
     <style>
       .settings-grid {
@@ -115,7 +115,7 @@
       <header class="hero">
         <div class="brand">
           <div class="brand-mark" aria-hidden="true">
-            <img src="../assets/icons/icon-48.png" alt="" />
+            <img src="../assets/icons/icon-v2-48.png" alt="" />
           </div>
           <div>
             <h1>Settings</h1>