Take another stab at detecting inactive subscriptions (#386)

Author: bachya

simplipy/api.py

@@ -348,7 +348,7 @@ async def async_get_systems(self) -> dict[int, SystemV2 | SystemV3]:
         await self.async_update_subscription_data()
 
         for sid, subscription in self.subscription_data.items():
-            if subscription["activated"] == 0 or not subscription["status"]["isActive"]:
+            if not subscription["status"]["hasBaseStation"]:
                 LOGGER.info("Skipping inactive subscription: %s", sid)
                 continue
 

tests/system/test_base.py

@@ -34,7 +34,7 @@ async def test_deactivated_system(
         authenticated_simplisafe_server: A authenticated API connection.
         subscriptions_response: An API response payload.
     """
-    subscriptions_response["subscriptions"][0]["activated"] = 0
+    subscriptions_response["subscriptions"][0]["status"]["hasBaseStation"] = 0
 
     async with authenticated_simplisafe_server:
         authenticated_simplisafe_server.add(