Adding ::equals method to ByteSequence and Token class

Author: nyamsprod

.gitattributes

@@ -1,16 +1,14 @@
 * text=auto
 
-/docs               export-ignore
 /.github            export-ignore
+/docs               export-ignore
 /.editorconfig      export-ignore
 /.gitattributes     export-ignore
 /.gitignore         export-ignore
 /.php-cs-fixer.php  export-ignore
-/phpstan.neon       export-ignore
 /CHANGELOG.md       export-ignore
 /README.md          export-ignore
+/phpstan.neon       export-ignore
 /phpunit.xml        export-ignore
-/Makefile           export-ignore
 /**/*Test.php       export-ignore
 /**/Test**          export-ignore
-/rector.php         export-ignore

CHANGELOG.md

@@ -16,6 +16,7 @@ All Notable changes to `bakame/http-strucured-fields` will be documented in this
 - `Type` Enum to list all possible Item Type supported.
 - `Value` Interface is introduced with `Item` being the only available implementation.
 - `MemberOrderedMap::add` and `MemberOrderedMap::remove` methods
+- `ByteSequence::equals` and `Token::equals` to easily compare type instances.
 
 ### Fixed
 

src/ByteSequence.php

@@ -60,4 +60,9 @@ public function encoded(): string
     {
         return base64_encode($this->value);
     }
+
+    public function equals(mixed $other): bool
+    {
+        return $other instanceof self && $other->value === $this->value;
+    }
 }

src/Item.php

@@ -195,9 +195,8 @@ public function value(): Token|ByteSequence|DateTimeImmutable|string|int|float|b
     public function withValue(mixed $value): static
     {
         return match (true) {
-            $value instanceof ByteSequence && $this->value instanceof ByteSequence && $value->encoded() === $this->value->encoded(),
-            $value instanceof Token && $this->value instanceof Token && $value->value === $this->value->value,
-            $value instanceof DateTimeInterface && $this->value instanceof DateTimeInterface && $value == $this->value,
+            ($this->value instanceof ByteSequence || $this->value instanceof Token) && $this->value->equals($value),
+            $this->value instanceof DateTimeInterface && $value instanceof DateTimeInterface && $value == $this->value,
             $value instanceof Stringable && $value->__toString() === $this->value,
             $value === $this->value => $this,
             default => self::from($value, $this->parameters),
@@ -249,7 +248,7 @@ public function toHttpValue(): string
         return match (true) {
             is_string($this->value) => '"'.preg_replace('/(["\\\])/', '\\\$1', $this->value).'"',
             is_int($this->value) => (string) $this->value,
-            is_float($this->value) => $this->serializeDecimal($this->value),
+            is_float($this->value) => self::serializeDecimal($this->value),
             is_bool($this->value) => '?'.($this->value ? '1' : '0'),
             $this->value instanceof Token => $this->value->value,
             $this->value instanceof DateTimeImmutable => '@'.$this->value->getTimestamp(),
@@ -262,7 +261,7 @@ public function toHttpValue(): string
      *
      * @see https://www.rfc-editor.org/rfc/rfc8941.html#section-4.1.5
      */
-    private function serializeDecimal(float $value): string
+    private static function serializeDecimal(float $value): string
     {
         /** @var string $result */
         $result = json_encode(round($value, 3, PHP_ROUND_HALF_EVEN));

src/Token.php

@@ -23,4 +23,9 @@ public static function fromString(Stringable|string $value): self
     {
         return new self((string) $value);
     }
+
+    public function equals(mixed $other): bool
+    {
+        return $other instanceof self && $other->value === $this->value;
+    }
 }

src/Type.php

@@ -30,7 +30,7 @@ public static function fromValue(mixed $value): self
             is_bool($value) => self::Boolean,
             is_int($value) => self::Integer,
             is_float($value) => self::Decimal,
-            default => throw new SyntaxError('Unknown or unsupported type.'),
+            default => throw new SyntaxError('The type "'.(is_object($value) ? $value::class : gettype($value)).'" is not supported.'),
         };
     }
 }