Merge pull request #250 from BalancerMaxis/enforce-bribe-minimums

enforce bribe threshold edge case with no qualifying core pools

Author: Xeonus

fee_allocator/fee_allocator.py

@@ -93,6 +93,15 @@ def redistribute_fees(self):
             pools_to_receive = [p for p in chain.core_pools if p.total_to_incentives_usd >= min_amount]
 
             if not pools_to_receive:
+                # no qualifying pools for chain, send to dao/vebal
+                for pool in pools_to_redistribute:
+                    amount = pool.total_to_incentives_usd
+                    pool.to_dao_usd += amount * self.run_config.fee_config.noncore_dao_share_pct
+                    pool.to_vebal_usd += amount * self.run_config.fee_config.noncore_vebal_share_pct
+                    pool.redirected_incentives_usd -= amount
+                    pool.to_aura_incentives_usd = Decimal(0)
+                    pool.to_bal_incentives_usd = Decimal(0)
+                    pool.total_to_incentives_usd = Decimal(0)
                 continue
 
             total_fees_to_redistribute = sum(p.total_to_incentives_usd for p in pools_to_redistribute)

multisig-ops

@@ -0,0 +1 @@
+Subproject commit 5f170f855edd45a12bd5906353662c35f3c853db

tests/conftest.py

@@ -45,14 +45,9 @@ def chain(run_config, web3):
 @pytest.fixture
 def allocator(fee_period):
     input_fees = {
-        "mainnet": Decimal("1000000"),
-        "arbitrum": Decimal("1000000"),
-        "polygon": Decimal("1000000"),
-        "optimism": Decimal("1000000"),
-        "base": Decimal("1000000"),
-        "gnosis": Decimal("1000000"),
-        "avalanche": Decimal("1000000"),
-        "plasma": Decimal("1000000"),
+        "mainnet": Decimal("100000"),
+        "arbitrum": Decimal("100000"),
+        "base": Decimal("100000"),
     }
 
     return FeeAllocator(

tests/test_allocator.py

@@ -101,12 +101,10 @@ def test_overall_dao_vebal_allocation(allocated_allocator: FeeAllocator):
 def test_core_pool_allocation(allocated_allocator: FeeAllocator):
     """Test that standard core pool allocations match configured percentages"""
     fee_config = allocated_allocator.run_config.fee_config
-    
     total_core_fees = Decimal(0)
     total_core_dao = Decimal(0)
     total_core_vebal = Decimal(0)
     total_core_incentives = Decimal(0)
-    
     for chain in allocated_allocator.run_config.all_chains:
         for pool in chain.core_pools:
             # Only include standard core pools
@@ -122,12 +120,12 @@ def test_core_pool_allocation(allocated_allocator: FeeAllocator):
         core_vebal_pct = total_core_vebal / total_core_allocations
         core_incentives_pct = total_core_incentives / total_core_allocations
 
-        assert abs(core_dao_pct - fee_config.dao_share_pct) <= Decimal('0.02'), \
-            f"Core pool DAO {core_dao_pct:.4f} not within 2% of target {fee_config.dao_share_pct}"
-        assert abs(core_vebal_pct - fee_config.vebal_share_pct) <= Decimal('0.02'), \
-            f"Core pool veBAL {core_vebal_pct:.4f} not within 2% of target {fee_config.vebal_share_pct}"
-        assert abs(core_incentives_pct - fee_config.vote_incentive_pct) <= Decimal('0.03'), \
-            f"Core pool incentives {core_incentives_pct:.4f} not within 2% of target {fee_config.vote_incentive_pct}"
+        assert abs(core_dao_pct - fee_config.dao_share_pct) <= Decimal('0.04'), \
+            f"Core pool DAO {core_dao_pct:.4f} not within 4% of target {fee_config.dao_share_pct}"
+        assert abs(core_vebal_pct - fee_config.vebal_share_pct) <= Decimal('0.15'), \
+            f"Core pool veBAL {core_vebal_pct:.4f} not within 15% of target {fee_config.vebal_share_pct}"
+        assert abs(core_incentives_pct - fee_config.vote_incentive_pct) <= Decimal('0.20'), \
+            f"Core pool incentives {core_incentives_pct:.4f} not within 20% of target {fee_config.vote_incentive_pct}"
 
 
 def test_noncore_allocation(allocated_allocator: FeeAllocator):