refactor: remove unused 'create_new' arg from 'update_yaml_file()'

Author: christiansiegel

gitopscli/yaml/yaml_util.py

@@ -20,21 +20,19 @@ def get_string(self):
     return stream.get_string()
 
 
-def update_yaml_file(file_path, key, value, create_new=False):
+def update_yaml_file(file_path, key, value):
     yaml = YAML()
     with open(file_path, "r") as stream:
         content = yaml.load(stream)
 
     keys, obj = key.split("."), content
     for k in keys[:-1]:
         if k not in obj or not isinstance(obj[k], dict):
-            if not create_new:
-                raise KeyError(f"Key '{key}' not found in YAML!")
-            obj[k] = dict()
+            raise KeyError(f"Key '{key}' not found in YAML!")
         obj = obj[k]
     if keys[-1] in obj and obj[keys[-1]] == value:
         return False  # nothing to update
-    if not create_new and keys[-1] not in obj:
+    if keys[-1] not in obj:
         raise KeyError(f"Key '{key}' not found in YAML!")
     obj[keys[-1]] = value
 

tests/yaml/test_yaml_util.py

@@ -72,48 +72,6 @@ def test_update_yaml_file(self):
 
         with pytest.raises(KeyError):
             updated = update_yaml_file(test_file, "a.x", "foo")
-        updated = update_yaml_file(test_file, "a.x", "foo", create_new=True)
-        self.assertTrue(updated)
-
-        expected = """\
-a: # comment
-# comment
-  b:
-    d: 1 # comment
-    c: '2' # comment
-  x: foo
-"""
-        actual = self._read_file(test_file)
-        self.assertEqual(expected, actual)
-
-        with pytest.raises(KeyError):
-            updated = update_yaml_file(test_file, "a.x.z", "foo_z")
-        updated = update_yaml_file(test_file, "a.x.z", "foo_z", create_new=True)
-        self.assertTrue(updated)
-
-        with pytest.raises(KeyError):
-            updated = update_yaml_file(test_file, "a.x.y", "foo_y")
-        updated = update_yaml_file(test_file, "a.x.y", "foo_y", create_new=True)
-        self.assertTrue(updated)
-
-        with pytest.raises(KeyError):
-            updated = update_yaml_file(test_file, "a.x.y.z", "foo_y_z")
-        updated = update_yaml_file(test_file, "a.x.y.z", "foo_y_z", create_new=True)
-        self.assertTrue(updated)
-
-        expected = """\
-a: # comment
-# comment
-  b:
-    d: 1 # comment
-    c: '2' # comment
-  x:
-    z: foo_z
-    y:
-      z: foo_y_z
-"""
-        actual = self._read_file(test_file)
-        self.assertEqual(expected, actual)
 
     def test_merge_yaml_element(self):
         test_file = self._create_file(