Skip to content

Commit 30ef3e1

Browse files
author
Luke Bakken
committed
prevent duplicate loading of test data
1 parent 866259f commit 30ef3e1

2 files changed

Lines changed: 30 additions & 14 deletions

File tree

riak/tests/test_btypes.py

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -151,13 +151,18 @@ def test_multiget_bucket_types(self):
151151
self.assertEqual(btype, mobj.bucket.bucket_type)
152152

153153
def test_write_once_bucket_type(self):
154-
btype = self.client.bucket_type('write_once')
155-
bucket = btype.bucket(self.bucket_name)
156-
157-
for i in range(100):
158-
obj = bucket.new(self.key_name + str(i))
159-
obj.data = {'id': i}
160-
obj.store()
154+
bt = 'write_once'
155+
skey = 'write_once-init'
156+
btype = self.client.bucket_type(bt)
157+
bucket = btype.bucket(bt)
158+
sobj = bucket.get(skey)
159+
if not sobj.exists:
160+
for i in range(100):
161+
o = bucket.new(self.key_name + str(i))
162+
o.data = {'id': i}
163+
o.store()
164+
o = bucket.new(skey, data={'id': skey})
165+
o.store()
161166

162167
mget = bucket.multiget([self.key_name + str(i) for i in range(100)])
163168
for mobj in mget:

riak/tests/test_kv.py

Lines changed: 18 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -180,17 +180,29 @@ def test_string_bucket_name(self):
180180
def test_generate_key(self):
181181
# Ensure that Riak generates a random key when
182182
# the key passed to bucket.new() is None.
183-
bucket = self.client.bucket('random_key_bucket')
184-
existing_keys = bucket.get_keys()
183+
bucket = self.client.bucket(self.bucket_name)
185184
o = bucket.new(None, data={})
186185
self.assertIsNone(o.key)
187186
o.store()
188187
self.assertIsNotNone(o.key)
189188
self.assertNotIn('/', o.key)
190-
self.assertNotIn(o.key, existing_keys)
191-
self.assertEqual(len(bucket.get_keys()), len(existing_keys) + 1)
189+
existing_keys = bucket.get_keys()
190+
self.assertEqual(len(existing_keys), 1)
191+
192+
def maybe_store_keys(self):
193+
skey = 'rkb-init'
194+
bucket = self.client.bucket('random_key_bucket')
195+
sobj = bucket.get(skey)
196+
if sobj.exists:
197+
return
198+
for key in range(1, 1000):
199+
o = bucket.new(None, data={})
200+
o.store()
201+
o = bucket.new(skey, data={})
202+
o.store()
192203

193204
def test_stream_keys(self):
205+
self.maybe_store_keys()
194206
bucket = self.client.bucket('random_key_bucket')
195207
regular_keys = bucket.get_keys()
196208
self.assertNotEqual(len(regular_keys), 0)
@@ -203,10 +215,8 @@ def test_stream_keys(self):
203215
self.assertEqual(sorted(regular_keys), sorted(streamed_keys))
204216

205217
def test_stream_keys_timeout(self):
218+
self.maybe_store_keys()
206219
bucket = self.client.bucket('random_key_bucket')
207-
for key in range(1, 1000):
208-
o = bucket.new(None, data={})
209-
o.store()
210220
streamed_keys = []
211221
with self.assertRaises(RiakError):
212222
for keylist in self.client.stream_keys(bucket, timeout=1):
@@ -216,6 +226,7 @@ def test_stream_keys_timeout(self):
216226
streamed_keys += keylist
217227

218228
def test_stream_keys_abort(self):
229+
self.maybe_store_keys()
219230
bucket = self.client.bucket('random_key_bucket')
220231
regular_keys = bucket.get_keys()
221232
self.assertNotEqual(len(regular_keys), 0)

0 commit comments

Comments
 (0)