Skip to content

Commit b85d3b4

Browse files
authored
Merge pull request #506 from basho/fixes/lrb/socket-options-iteritems
Use six.iteritems for compatibility
2 parents ff9a371 + be8e21f commit b85d3b4

3 files changed

Lines changed: 7 additions & 6 deletions

File tree

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,7 @@ Contributors
142142
* Soren Hansen
143143
* Sreejith Kesavan
144144
* Timothée Peignier
145+
* [Tin Tvrtković](https://github.com/Tinche)
145146
* [Vitaly Shestovskiy](https://github.com/lamp0chka)
146147
* William Kral
147148
* [Yasser Souri](https://github.com/yassersouri)

riak/codecs/http.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import re
22
import csv
3+
import six
34

4-
from six import PY2, PY3
55
from cgi import parse_header
66
from email import message_from_string
77
from email.utils import parsedate_tz, mktime_tz
@@ -13,7 +13,7 @@
1313
from riak.transports.http.search import XMLSearchResult
1414
from riak.util import decode_index_value, bytes_to_str
1515

16-
if PY2:
16+
if six.PY2:
1717
from urllib import unquote_plus
1818
else:
1919
from urllib.parse import unquote_plus
@@ -63,7 +63,7 @@ def _parse_body(self, robj, response, expected_statuses):
6363
elif status == 300:
6464
ctype, params = parse_header(headers['content-type'])
6565
if ctype == 'multipart/mixed':
66-
if PY3:
66+
if six.PY3:
6767
data = bytes_to_str(data)
6868
boundary = re.compile('\r?\n--%s(?:--)?\r?\n' %
6969
re.escape(params['boundary']))
@@ -225,7 +225,7 @@ def _normalize_json_search_response(self, json):
225225
# Riak Search 1.0 Legacy assumptions about format
226226
resdoc[u'id'] = doc[u'id']
227227
if u'fields' in doc:
228-
for k, v in doc[u'fields'].iteritems():
228+
for k, v in six.iteritems(doc[u'fields']):
229229
resdoc[k] = v
230230
docs.append(resdoc)
231231
result['docs'] = docs

riak/transports/tcp/connection.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
import logging
33
import socket
44
import struct
5-
5+
import six
66
import riak.pb.riak_pb2
77
import riak.pb.messages
88

@@ -241,7 +241,7 @@ def _connect(self):
241241
self._socket = socket.create_connection(self._address)
242242
if self._socket_tcp_options:
243243
ka_opts = self._socket_tcp_options
244-
for k, v in ka_opts.iteritems():
244+
for k, v in six.iteritems(ka_opts):
245245
self._socket.setsockopt(socket.SOL_TCP, k, v)
246246
if self._socket_keepalive:
247247
self._socket.setsockopt(

0 commit comments

Comments
 (0)