formatting and linting

Author: phernandez

TODO.md

@@ -36,7 +36,9 @@
     - https://docs.render.com/docker
 - [ ] multi tenant
 - [ ] postgres row level security
-- [ ] stripe integration
+- [ ] subscriptions
+    - stripe integration
+    - lago
 - [ ] webhooks
 - [ ] queueing
 - [ ] static object storage

foundation/app.py

@@ -15,6 +15,9 @@
 
 from modules.foundation.api.routes import api_router  # Import the router from api module
 from modules.foundation.web.routes import html_router  # Import the router from web module
+from fastapi.exception_handlers import (
+    http_exception_handler,
+)
 
 # delete all existing default loggers
 logger.remove()
@@ -49,9 +52,6 @@ async def on_startup():  # pragma: no cover
     init_data.main()
 
 
-from fastapi.exception_handlers import (
-    http_exception_handler,
-)
 
 
 @app.exception_handler(StarletteHTTPException)

foundation/conftest.py

@@ -1,21 +1,17 @@
 import asyncio
-from typing import AsyncGenerator, Generator
+from typing import AsyncGenerator
 
 import pytest
 import pytest_asyncio
-from httpx import AsyncClient
 from sqlalchemy import event
 from sqlalchemy.ext.asyncio import AsyncSession
 from sqlalchemy.orm import sessionmaker
 
-from foundation.app import app
 from foundation.core import security
 from foundation.core.db import engine
 from foundation.core.repository import Repository
-from foundation.users.deps import get_user_repository
 from foundation.users.models import User
 from foundation.test_utils import (
-    get_superuser_auth_token_headers,
     random_email,
 )
 

foundation/core/deps.py

@@ -16,7 +16,7 @@ async def get_async_session() -> AsyncGenerator[AsyncSession, None]:  # pragma:
     async with async_sessionmaker() as session:
         try:
             yield session
-        except SQLAlchemyError as e:
+        except SQLAlchemyError:
             # Handle SQLAlchemy specific exceptions
             raise HTTPException(
                 status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,

foundation/core/repository.py

@@ -86,7 +86,7 @@ async def delete(self, entity_id: UUID) -> bool:
             await self.session.delete(entity)
             await self.session.commit()
             return True
-        except NoResultFound as e:
+        except NoResultFound:
             return False
 
     async def count(self, query: Executable | None = None) -> int:

foundation/test/test_main.py

@@ -1,4 +1,3 @@
-from typing import AsyncGenerator, Generator
 
 import pytest
 from foundation.app import app

foundation/test_utils.py

@@ -27,7 +27,7 @@ async def get_superuser_auth_token_headers(client: AsyncClient) -> dict[str, str
 
 
 async def get_auth_token(client: AsyncClient, login_data: dict[str, str]) -> AuthToken: # pragma: no cover
-    r = await client.post(f"/api/auth/login/access-token", data=login_data)
+    r = await client.post("/api/auth/login/access-token", data=login_data)
     assert r.status_code == 200, r.text
     return AuthToken.model_validate(r.json())
 

foundation/users/services.py

@@ -1,8 +1,8 @@
-from typing import Any, Sequence, Tuple
+from typing import Any, Sequence
 from uuid import UUID
 
 from loguru import logger
-from sqlalchemy import select, func, Select
+from sqlalchemy import select, func
 from sqlalchemy.exc import IntegrityError
 
 from foundation.core.config import settings

foundation/users/test/test_user_pagination.py

@@ -1,4 +1,3 @@
-import uuid
 from unittest.mock import Mock
 
 import pytest
@@ -8,16 +7,11 @@
 from foundation.users.deps import UserPagination
 from foundation.users.models import User
 from foundation.core.pagination import Paginator
-import pytest
-import pytest_asyncio
 from mockito import when, mock
-from sqlalchemy import select
 from starlette import requests
 from starlette.datastructures import URL
 
 from foundation.core.repository import Repository
-from foundation.users.models import User
-from foundation.core.pagination import Paginator
 
 pytestmark = pytest.mark.asyncio
 
@@ -53,7 +47,7 @@ async def test_user_pagination(user_repository):
     assert paginator.query == query
     assert paginator.page_size == page_size
     assert paginator.order_by == order_by
-    assert paginator.ascending == False
+    assert paginator.ascending is False
     assert paginator.repository == user_repository
     assert paginator.request == request
 

foundation/users/test/test_user_services.py

@@ -1,14 +1,8 @@
 import uuid
-from unittest.mock import Mock
 
 import pytest
 import pytest_asyncio
-from mockito import mock, when, unstub
-from sqlalchemy import select
-from fastapi import Request
 
-from foundation.core import emails
-from foundation.core.emails import send_email
 from foundation.core.security import verify_password
 from foundation.users.models import User
 from foundation.users.services import (
@@ -157,7 +151,7 @@ async def test_update_user_fails(user_service, sample_user: User):
         "is_active": True,
         "is_superuser": True,
     }
-    with pytest.raises(UserValueError, match=f"user can not be updated"):
+    with pytest.raises(UserValueError, match="user can not be updated"):
         await user_service.update_user(user_id=created_user.id, update_dict=user_update)